ci: use edition 2024 merged doctests under wasm & valgrind - #6386
davidhewitt wants to merge 16 commits into
Conversation
Merging this PR will degrade performance by 8.95%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | into_u128_small |
820.5 ns | 1,041.4 ns | -21.21% |
| ❌ | into_u128_zero |
816 ns | 981.3 ns | -16.84% |
| ❌ | extract_bigint_small |
1.5 µs | 1.6 µs | -10.2% |
| ⚡ | into_biguint_small |
1.5 µs | 1.3 µs | +16.79% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing davidhewitt:merged-wasm-doctests (d7dc6dd) with main (ff1316b)
Footnotes
-
6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
|
I'm playing around with the full version bump to 1.85 & edition 2024 to see what gains we get. Taking a bit of work to run the experiment, but initial results locally suggest it might net some decent wins. |
This is an experiment to see if wasm and valgrind jobs can run faster if we update to use merged doctests. If successful, we could instead consider MSRV bump to 1.85