fix reference to type being borrowed inside #[classmethod] dunder methods - #6420
Merged
Merged
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
Icxolu
approved these changes
Sep 15, 2026
Icxolu
left a comment
Member
There was a problem hiding this comment.
Looks correct (and also a bit cleaner)
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #6386 I noticed a questionable call to
Py_TYPEinside macro code to create#[classmethod]receivers from instance values. The call didn't increase the refcount of the type object; I'm pretty confident that this could lead to bugs if__class__was reassigned on the object and it caused the type object to be garbage collected.I didn't bother writing a test because it'd be pretty painful to hit the problem conditions and it feels like the sort of thing where now it's done correctly we're unlikely to regress it.