Repository navigation
fix(esign): list registered eligible signers before first visit - #79
Merged
Merged
Conversation
Read registered identities from the IdP, apply current signing permissions and drive rules, and sync selected signer profiles when creating a request.
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 4
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 17, 2026
lorenzocorallo
marked this pull request as ready for review
October 17, 2026 16:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
esign:signand each selected drive's sign rule before listing or accepting a signer.Verification
bun run checkbun run typecheckbun run test(124 passed, 8 skipped)bun run buildbun run build:npmRollout
Depends on PoliNetworkOrg/auth#63. Deploy auth first so the registered-user endpoint exists before this backend starts using it. A focused regression test covers a registered signer who has never opened Signatures.