Skip to content

fix(esign): explain registered signer eligibility - #113

Merged
lorenzocorallo merged 1 commit into
mainfrom
fix/esign-registered-picker
Oct 17, 2026
Merged

lorenzocorallo merged 1 commit into
mainfrom
fix/esign-registered-picker

Conversation

@lorenzocorallo

Copy link
Copy Markdown
Member

Summary

  • Explain that the signer picker uses registered users with signing permission.
  • Remove the outdated instruction that users must open Signatures before appearing.
  • Keep the existing selected-drive eligibility explanation.

Verification

  • pnpm check
  • pnpm typecheck
  • pnpm test (43 passed, 3 skipped)
  • pnpm build

Rollout

The actual signer-directory behavior depends on PoliNetworkOrg/auth#63 and PoliNetworkOrg/backend#79. The dashboard's other in-progress Signatures edits were left out of this PR.

The picker now describes IdP registration and signing permission instead of requiring a prior Signatures visit.
@coderabbitai

coderabbitai Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 74713de0-ff1e-42c1-a9a8-ce5d0f429d78
📥 Commits

Reviewing files that changed from the base of the PR and between 2be5a85 and dde190d.

📒 Files selected for processing: 2
  • docs/esign/contracts.md
  • src/features/esign/new-request-page.tsx
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lorenzocorallo
lorenzocorallo marked this pull request as ready for review October 17, 2026 16:06
@lorenzocorallo
lorenzocorallo merged commit 18c4c43 into main Oct 17, 2026
2 checks passed
@lorenzocorallo
lorenzocorallo deleted the fix/esign-registered-picker branch October 17, 2026 16:06
BIA3IA pushed a commit that referenced this pull request Oct 20, 2026
The picker now describes IdP registration and signing permission instead of requiring a prior Signatures visit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant