Skip to content

fix(esign): explain registered signer eligibility #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lorenzocorallo merged 1 commit into from
Oct 17, 2026
Merged

fix(esign): explain registered signer eligibility #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/esign/contracts.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ Permissions: `esign:sign` (see own inbox, sign when it is your turn), `esign:req
browse OneDrive). Requests are visible to their signers and creator.

- `esign.profile.sync({name, email})` → upserts the caller's signer profile (BFF passes ID-token claims).
- `esign.signers.list()` → signer profiles (manage).
- `esign.signers.list()` → registered IdP users with `esign:sign`, including those who have not opened Signatures; each includes eligible drives (manage).
- `esign.config()` → `{drives: [{id, label}], canManage, maxPdfBytes}`; `drives` is empty without OneDrive.
- `esign.drive.list({driveId, folderId?})` → `{folder, path, items: [{id, name, kind: folder|pdf, size, modifiedAt}]}`.
Item IDs are only unique within their drive, so every drive call names one.
Expand Down
10 changes: 6 additions & 4 deletions src/features/esign/new-request-page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,11 +621,13 @@ export function NewEsignRequestPage({
<li className="px-2 py-2 text-[13px] text-(--pn-fg-muted)">
{search.trim() !== ""
? "Nobody matches."
: eligible.length === 0
: eligible.length === 0 && usedDrives.length > 0
? `Nobody can sign documents of ${usedDrives.map(driveLabel).join(" and ")}. Who can is set in Signatures › Drives.`
: usedDrives.length > 0
? "Everyone allowed to sign these documents is added."
: "Everyone who can sign is added. People appear here after they open Signatures once."}
: eligible.length === 0
? "No registered people currently have permission to sign."
: usedDrives.length > 0
? "Everyone allowed to sign these documents is added."
: "Everyone who can sign is added."}
</li>
)}
</ul>
Expand Down
Loading