Skip to content

filters: address TODO in ModelOutlierRemoval compare content#6401

Merged
larshg merged 1 commit intoPointCloudLibrary:masterfrom
Stado1:fix-test-model-outlier-content
Jan 30, 2026
Merged

filters: address TODO in ModelOutlierRemoval compare content#6401
larshg merged 1 commit intoPointCloudLibrary:masterfrom
Stado1:fix-test-model-outlier-content

Conversation

@Stado1
Copy link
Contributor

@Stado1 Stado1 commented Jan 29, 2026

In test_model_outlier_removal.cpp there was a TODO for the comparison of two point contents. This PR implemented that comparison by:

  • Sorting RANSAC inliers to be in the same order as the filtered output
  • Using ASSERT_EQ for size verification to prevent out of bound access in the for loop
  • Comparing individual point coordinates using EXPECT_FLOAT_EQ

Copy link
Member

@mvieth mvieth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@larshg larshg added the changelog: enhancement Meta-information for changelog generation label Jan 30, 2026
@larshg larshg added this to the pcl-1.16.0 milestone Jan 30, 2026
@larshg larshg merged commit 87b078d into PointCloudLibrary:master Jan 30, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: enhancement Meta-information for changelog generation module: filters module: test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants