Conversation
This was referenced Sep 20, 2026
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Sep 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model instance factories returned the base Eloquent builder even when static queries used the model’s custom builder. Correct the factory methods’ instance/static distinction and preserve the custom builder and model through
newQuery(),newModelQuery(), andnewQueryWithoutScopes().Existing declarations retain their signatures and source metadata; explicit return types that select another builder or model remain authoritative. Return-type transformations use the existing interning cache.
Adds regression coverage for generic and non-generic builders, inherited configuration, explicit overrides, completion, and runtime behavior. Removes completed L55 from the backlog.
Stack: depends on #447. This stacked PR targets upstream
main, so its diff includes the unmerged dependency. The L55 change is commit7d608a7e; merge the dependency first.Validation: full cargo test, both required clippy runs, cargo fmt --check, PHP syntax/runtime assertions, and Laravel analysis with exactly its three intentional diagnostics.