Conversation
This was referenced Sep 20, 2026
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This was referenced Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relation callback inference assumed the first supplied argument named the relationship. Calls such as
Team::has(callback: ..., relation: 'stocks.warehouse')therefore lost the related model and custom builder. Bind the relation and callback against the installed method declaration using the shared argument binder, and apply the override only to the actual constraint argument.Adds regression coverage for reordered arguments, omitted defaults, static/instance/null-safe calls, block/arrow callbacks, the
whereRelationcolumn callback, and a closure in an unrelated parameter. Includes a Laravel demo and runtime assertion; removes completed L57 from the backlog.Stack: depends on #449 (L56), above #448 and #447. This stacked PR targets upstream
main, so its diff includes the unmerged dependencies. The final commit contains L57; merge the dependencies first.Validation: full cargo test, both required clippy runs, cargo fmt --check, PHP syntax/runtime assertions, and Laravel analysis with exactly its three intentional diagnostics.