Skip to content

Render Cemetery labels #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
CharliePlett wants to merge 2 commits into
base: staging
Choose a base branch
from
Draft

Render Cemetery labels #74

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1efcaee
Render Cemetery labels
CharliePlett Aug 6, 2026
300b0bd
Filter cemetery icons by religion
CharliePlett Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 71 additions & 0 deletions historical/historical.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6062,6 +6062,77 @@
"text-halo-width": 1
}
},
{
"id": "landuse_areas_labels_cemetery_christian",
"type": "symbol",
"source": "ohm",
"source-layer": "landuse_points_centroids",
"minzoom": 14,
"maxzoom": 24,
"filter": [
"all",
["==", ["get", "type"], "cemetery"],
["==", ["get", "religion"], "christian"],
[
"!",
[
"in",
["get", "denomination"],
["literal", ["jehovahs_witness", "mormon", "iglesia_ni_cristo"]]
]
]
],
"layout": {
"icon-image": "cross-18",

@1ec5 1ec5 Aug 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simple cross could get confused with a church. Some churches are located on cemetery grounds.

@CharliePlett CharliePlett Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll think up some new icon. Maybe a simple tombstone that's different than the gravestone

@1ec5 1ec5 Aug 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of duplicating the layer and negating the filter, keep just one layer but replace this property value with an expression. Use match expressions to keep it more readable:

[
  "match",
  ["get", "religion"],
  "christian",
  [
    "match",
    ["get", "denomination"],
    ["jehovahs_witness", "mormon", "iglesia_ni_cristo"],
    "",
    "cross-18"
  ],
  ""
]

You can do something similar with text-offset, but you’ll need to stuff the array in a literal expression, so it doesn’t get misinterpreted as an expression.

"text-field": ["get", "name"],
"text-size": 11,
"text-anchor": "top",
"text-offset": [0, 0.75],
"text-font": ["OpenHistorical"]
},
"paint": {
"text-color": "rgba(95, 107, 71, 1)",
"text-halo-color": "rgba(245, 239, 239, 1)",
"text-halo-width": 1
}
},
{
"id": "landuse_areas_labels_cemetery",
"type": "symbol",
"source": "ohm",
"source-layer": "landuse_points_centroids",
"minzoom": 14,
"maxzoom": 24,
"filter": [
"all",
["==", ["get", "type"], "cemetery"],
[
"!",
[
"all",
["==", ["get", "religion"], "christian"],
[
"!",
[
"in",
["get", "denomination"],
["literal", ["jehovahs_witness", "mormon", "iglesia_ni_cristo"]]
]
]
]
]
],
"layout": {
"text-field": ["get", "name"],
"text-size": 11,
"text-font": ["OpenHistorical"]
},
"paint": {
"text-color": "rgba(95, 107, 71, 1)",
"text-halo-color": "rgba(245, 239, 239, 1)",
"text-halo-width": 1
}
},
{
"id": "landuse_areas_labels_school",
"type": "symbol",
Expand Down