Render Cemetery labels - #74
Draft
CharliePlett wants to merge 2 commits into
Draft
Conversation
CharliePlett
marked this pull request as draft
August 6, 2026 20:11
CharliePlett
marked this pull request as ready for review
August 6, 2026 21:22
1ec5
reviewed
Aug 7, 2026
| ] | ||
| ], | ||
| "layout": { | ||
| "icon-image": "cross-18", |
Member
There was a problem hiding this comment.
A simple cross could get confused with a church. Some churches are located on cemetery grounds.
Contributor
Author
There was a problem hiding this comment.
Ok, I'll think up some new icon. Maybe a simple tombstone that's different than the gravestone
| ] | ||
| ], | ||
| "layout": { | ||
| "icon-image": "cross-18", |
Member
There was a problem hiding this comment.
Instead of duplicating the layer and negating the filter, keep just one layer but replace this property value with an expression. Use match expressions to keep it more readable:
[
"match",
["get", "religion"],
"christian",
[
"match",
["get", "denomination"],
["jehovahs_witness", "mormon", "iglesia_ni_cristo"],
"",
"cross-18"
],
""
]You can do something similar with text-offset, but you’ll need to stuff the array in a literal expression, so it doesn’t get misinterpreted as an expression.
CharliePlett
marked this pull request as draft
August 7, 2026 20:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a label and an icon for landuse=cemetery. This pull request closes #1413