Skip to content

Reduce module variables included in Option 1 solve with ServoDyn #3261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deslaughter merged 2 commits into from
Mar 12, 2026
+15 −5
Merged

Reduce module variables included in Option 1 solve with ServoDyn #3261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef8a459
Try to fix simulations failing to converge with structural controller…
deslaughter Mar 12, 2026
abb1f5d
Update r-test pointer
deslaughter Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions modules/openfast-library/src/FAST_Solver.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,15 +488,25 @@ subroutine SetVarSolveFlags()
do i = 1, size(SrcMod%Vars%y)
associate (Var => SrcMod%Vars%y(i))
if (.not. MV_EqualDL(Mapping%SrcDL, Var%DL)) cycle
call MV_SetFlags(Var, VF_Solve)
select case (Var%Field)
case (FieldForce, FieldMoment)
call MV_SetFlags(Var, VF_Solve)
case (FieldScalar)
if (Var%DerivOrder == 2) call MV_SetFlags(Var, VF_Solve)
end select
end associate
end do

! Add flag to destination variable
do i = 1, size(DstMod%Vars%u)
associate (Var => DstMod%Vars%u(i))
if (.not. MV_EqualDL(Mapping%DstDL, Var%DL)) cycle
call MV_SetFlags(Var, VF_Solve)
select case (Var%Field)
case (FieldForce, FieldMoment)
call MV_SetFlags(Var, VF_Solve)
case (FieldScalar)
if (Var%DerivOrder == 2) call MV_SetFlags(Var, VF_Solve)
end select
end associate
end do

Expand Down
4 changes: 2 additions & 2 deletions modules/servodyn/src/ServoDyn.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,7 +643,7 @@ subroutine SrvD_InitVars(InitInp, u, p, x, y, m, InitOut, Linearize, ErrStat, Er
do k = 1, size(StCInds)
call MV_AddVar(InitOut%Vars%x, Desc, FieldScalar, DatLoc(SrvD_x_BStC_StC_x, j), &
iAry=StCInds(k), jAry=i, &
Flags=VF_DerivOrder2+VF_RotFrame, &
Flags=ior(VF_DerivOrder2,VF_RotFrame), &
LinNames=[trim(Desc)//StCLabels(StCInds(k))], &
Perturb=xPerturb)
end do
Expand Down Expand Up @@ -696,7 +696,7 @@ subroutine SrvD_InitVars(InitInp, u, p, x, y, m, InitOut, Linearize, ErrStat, Er

call MV_AddVar(InitOut%Vars%u, "BlPitch", FieldScalar, &
DatLoc(SrvD_u_BlPitch), &
Flags=VF_RotFrame + VF_2PI, &
Flags=ior(VF_RotFrame, VF_2PI), &
Num=size(u%BlPitch), &
Perturb=uPerturbAng, &
LinNames=[('BlPitch('//trim(Num2LStr(i))//'), rad', i = 1, size(u%BlPitch))])
Expand Down
2 changes: 1 addition & 1 deletion reg_tests/r-test
Open in desktop
Submodule r-test updated 2 files
+ − glue-codes/openfast/5MW_Land_BD_DLL_WTurb_StC/5MW_Land_BD_DLL_WTurb_StC.outb
+ − glue-codes/openfast/IEA22MW_ModalDamping/IEA22MW_ModalDamping.outb
Loading