Reduce module variables included in Option 1 solve with ServoDyn#3261
Merged
deslaughter merged 2 commits intoOpenFAST:devfrom Mar 12, 2026
Merged
Reduce module variables included in Option 1 solve with ServoDyn#3261deslaughter merged 2 commits intoOpenFAST:devfrom
deslaughter merged 2 commits intoOpenFAST:devfrom
Conversation
deslaughter
requested review from
andrew-platt and
Copilot
and removed request for
Copilot
deslaughter
changed the title
andrew-platt
approved these changes
Mar 12, 2026
Collaborator
andrew-platt
left a comment
andrew-platt
left a comment
There was a problem hiding this comment.
I can't say I fully understand the changes, but the resulting improvement in the testing looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is ready to merge pending regression test results.
Feature or improvement description
There was an issue with the inclusion of certain module variables in the Option 1 solve when Structural Controllers were enabled in ServoDyn which caused the models to not converge. This PR adjusts the code to exclude variables that aren't related to force or acceleration. This may impact #3210, but the issue can be explored further in that PR. This one gets the structural controller working again.
Impacted areas of the software
FAST_Solver.f90