Repository navigation
fix: clarify recovery conflicts and preview saved contents - #36
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
4 of 21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When another tab changes local recovery, the conflict message leaves users unsure whether Retry will replace their live project. Explain that Retry only inspects the saved copy, and state what Restore and Discard keep. Show the pending copy’s actual saved time, filenames, unapplied-draft count and per-file applied/draft byte sizes before replacement.
Strengthen the real two-tab browser scenarios to cover both decisions, cancelled restore confirmation and exact draft preservation. The reload scenario now saves distinguishable successive drafts and verifies that the latest successfully saved source, drafts and both view layouts restore exactly. Add reviewed light/dark desktop/narrow captures and update the user and verification documentation.
Closes #15.
Closes #23.
Validation
npm run check: formatting, architecture, TypeScript, 160 Vitest tests and 10 Node checks passed.npm run test:e2e -- --project=functional recovery.spec.ts: all 10 recovery scenarios passed after a fresh production build.npm run test:e2e -- --project=visual --grep 'local recovery dialog|recovery conflict and saved-copy': all 8 scenarios passed without baseline updates after review.The existing storage conflict policy and persistence formats are unchanged. These tests do not establish the cause of the report’s original condensed/older recovery copy or demonstrate a fix for silent data loss. Full suites outside recovery and manual screen-reader verification were not run. Hosted CI and deployment are separate from these local results.