Skip to content

fix: preserve inherited view members and scope recovery errors - #37

Open
rororowyourboat wants to merge 4 commits into
developfrom
fix/wp26-inspection
Open

rororowyourboat wants to merge 4 commits into
developfrom
fix/wp26-inspection

Conversation

@rororowyourboat

Copy link
Copy Markdown
Member

Change

Authored interconnection views omitted inherited structural members from typed usages. Retain the native effective occurrences with exact declaration/usage correspondence, reserve legacy node/port IDs for positioned projects, and place newly visible inherited nodes within existing owner bounds without changing ordinary authored-node placement. Keyboard structural selection now updates Properties.

After accepting recovery, a visualization failure could enter the recovery error channel and survive a later successful action. Route that refresh through the generation-aware workbench action channel while preserving rejected-restore handling and current actionable errors.

Fixes #14. Fixes #18.

Also retain the #20 exposure investigation and executable upstream reproduction. Immediate exposure can legitimately include private imported memberships; a separate intermediate-import visibility defect remains unresolved. No unsafe resolver experiment is integrated and this PR does not close #20.

Evidence

  • npm run engines:prepare: complete combined Go bridge suite passed; 16 exact inherited-occurrence cases include negative controls for pruning and legacy-ID reservation.
  • npm run check: formatting, architecture, TypeScript, 166 unit tests and 10 script tests passed.
  • Final selected real-engine browser run: all 13 passed (nine authoring/preservation/inherited-member workflows and four desktop/narrow light/dark visual comparisons), without baseline updates. This includes the unchanged creation/connect/undo/redo/save/fresh-reopen case and exact old positioned-project restoration.
  • Recovery error-lifetime plus existing recovery suite: all 11 scenarios passed. Critical browser gate plus full engine compatibility scenario: all 18 passed at the earlier checkpoint.
  • Full visual project: 89 passed before the final inherited-only placement refinement; the four affected visual cases were compared again on final code. Existing baselines were unchanged. New snapshots were inspected.
  • Important regressions failed before their fixes. Independent bridge, integration, layout and final inherited-scope reviews found no confirmed blocking defects. The verification record retains intermediate failures and rejected placement candidates rather than concealing them.

Fresh production builds ran through Playwright. Full functional coverage outside the recorded subsets, Firefox/WebKit, complete accessibility auditing and large-model performance were not run. Hosted CI for this PR and deployment are separate from local results.

Compatibility

Engine pins, dependencies and the version-1 saved project format are unchanged. The artifact contract validates the native optional inherited flag; it is not a persisted format field. Temporary exploration/tree ownership scope, attribute compartments and connector-selection policy remain unchanged. If saved geometry leaves no fitting slot for a new inherited node, the editor preserves saved positions and warns instead of inventing larger unsaved drag bounds. General manual overlap prevention is not provided.

This branch builds on merged recovery PR #36. The committed verification record and exposure investigation describe exact scope, engine provenance and unresolved findings.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T09:45:36.265072Z 3ca0d7f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant