Aditya - Job Application Listing Page: add the missing FAQ section - #5473
Open
AdiDubbs wants to merge 1 commit into
Open
Aditya - Job Application Listing Page: add the missing FAQ section#5473AdiDubbs wants to merge 1 commit into
AdiDubbs wants to merge 1 commit into
Conversation
Ports FAQSection across from VARSHA-KARANAM-FAQ-APPLICATION, where it was built but never merged into development. Renders answers through DOMPurify since /collaboration is reachable without signing in, drops the index-based hiding of questions 22 and 23, and adds dark mode styling and tests. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
AdiDubbs
marked this pull request as ready for review
August 30, 2026 03:12
iAbhi001
self-requested a review
August 30, 2026 05:40
iAbhi001
approved these changes
Aug 30, 2026
iAbhi001
left a comment
iAbhi001
left a comment
There was a problem hiding this comment.
LGTM! Tested locally on http://localhost:5173/collaboration:
- FAQ section renders properly below the job listings with sequential numbering and bold questions.
- Embedded "What is it like working with us?" video is present and aligned correctly.
- Verified dark mode and light mode rendering.
- Responsive layout stacks columns below 768px as expected.
- Unit tests pass locally.
Approved!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The FAQ section on the Job Application Listing Page has never existed on
development. This adds it, and makes it publicly accessible. This issue concerns Item 33.Conflicts and Issues Discovered
Earlier, there was an incorrect belief that the FAQ section is inaccessible because of a routing fault, but that is not the case. The section was built in #4055, which was closed without being merged on 12 January 2026. Its follow-up, #4342, was merged into the
VARSHA-KARANAM-FAQ-APPLICATIONbranch rather than intodevelopment— 62 seconds before #4055 was closed. That is why the work reads as complete while the section never appears:FAQSection.jsxandFAQSection.module.cssdo not exist ondevelopment, and nothing references them.Related PRS (if any):
Backend: OneCommunityGlobal/HGNRest#2324 — makes
GET /faqspublic. Required for the section to render for signed-out visitors.Replaces #5212, now closed. The code in #5212 was a job-summaries fix unrelated to this task, and no longer compiles against
development.Main changes explained:
FAQSection.jsxandFAQSection.module.cssfromVARSHA-KARANAM-FAQ-APPLICATIONand rendered the section fromCollaboration.jsx. Only these two files were taken across — the rest of that branch is superseded by later work on the page./collaborationis reachable without signing in, so unsanitised HTML from the FAQ database would have been exposed to visitors. DOMPurify is already a dependency and is used in the same way elsewhere in the app.index !== 21 && index !== 22). It breaks whenever an FAQ is added or reordered, and it had already drifted - it missed a third test row that was added later.darkModepattern already used inCollaboration.jsx.__tests__/FAQSection.test.jsx— 7 tests, 100% statements and functions, 92.85% branches on the new component.How to test:
npm install, thennpm run start:local/collaborationwithout signing in - the FAQ section should appear below the job listings, with the questions numbered and in boldnpm run test:changedNote that until OneCommunityGlobal/HGNRest#2324 merges, step 3 shows "Sign in to read the frequently asked questions" instead of the list. With that branch running locally, the list appears.
Screenshots or videos of changes:
Note:
Three rows in the FAQ database are leftovers from a Mongoose upgrade test in January — "Test Question for MongoDB Upgrade" and two copies of "MongoDB Upgrade Test Question". They are not introduced by this PR, but they become visible for the first time because of it, so they will appear in the deploy preview. They need deleting through FAQ management.