[19.0][FIX] stock_account: product.value and stock.valuation.layer have different semantics

[hbrunn]

this deals with the issue hinted at in #5855

[MiquelRForgeFlow]

BTW, is this PR ready to review and merge?

[hbrunn]

I forgot some details like lifting constraints on the svl table and linking product_value records to the svl they come from, but by and large, that's what I think should happen

[MiquelRForgeFlow]

@hbrunn please, rebase. I made an error when force pushing to 19.0 (it's already amended)

[hbrunn]

why is anyone allowed to force push in the first place?

[MiquelRForgeFlow]

I have just removed the force push permissions.

[hbrunn]

https://github.com/OCA/OpenUpgrade/settings/branch_protection_rules/5942394 looked like this:

I've changed that to

[MiquelRForgeFlow]

The option was marked in "Specify who can force push". I only removed the people there. So I suppose that when the list of people there is empty, github changes it to Everyone.

[hbrunn]

I forgot some details like lifting constraints on the svl table and linking product_value records to the svl they come from, but by and large, that's what I think should happen

that's done now

[MiquelRForgeFlow]

Could you attend my comments regarding logging/not logging queries? :)

[hbrunn]

done

[cuongnmtm]

My commit inside the PR fixes the wrong product cost issue in my DB

#5951

[cuongnmtm]

If you think it is ok, please cherry-pick so I can close my PR

[hbrunn]

the comments your bullshit generator adds keep referring to v17. but we don't care about v17, we care about v18. also see my comment in your PR, which fails the tests added