Skip to content

[19.0][OU-ADD] stock_landed_costs:Nothing to do - #5933

Merged
MiquelRForgeFlow merged 1 commit into
OCA:19.0from
Tecnativa:19.0-ou-add-stock_landed_costs
Aug 31, 2026
Merged

[19.0][OU-ADD] stock_landed_costs:Nothing to do#5933
MiquelRForgeFlow merged 1 commit into
OCA:19.0from
Tecnativa:19.0-ou-add-stock_landed_costs

Conversation

@carlos-lopez-tecnativa

Copy link
Copy Markdown
Contributor

TT64209
@Tecnativa @pedrobaeza @pilarvargas-tecnativa could you please review this?

@OCA-git-bot OCA-git-bot added mod:openupgrade_scripts Module openupgrade_scripts series:19.0 labels Aug 24, 2026
@carlos-lopez-tecnativa
carlos-lopez-tecnativa force-pushed the 19.0-ou-add-stock_landed_costs branch from 66ff23f to 98cb70b Compare August 24, 2026 15:57
@pedrobaeza

pedrobaeza commented Aug 24, 2026

Copy link
Copy Markdown
Member

/ocabot migration stock_landed_costs

Depends on :

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone Aug 24, 2026
@OCA OCA deleted a comment from OCA-git-bot Aug 24, 2026

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How these extra costs are reflected in the new structure? Isn't anything to mark or to sum or something?

@carlos-lopez-tecnativa

Copy link
Copy Markdown
Contributor Author

How these extra costs are reflected in the new structure? Isn't anything to mark or to sum or something?

The extra costs are applied when a landed cost is validated, and the logic is handled in the stock_account module.

The landed cost only calls the _set_value method, which retrieves the values from _get_value_data. In stock_landed_costs, the _get_value_from_extra method is inherited to return the extra cost.

In short, the logic is handled by stock_account. Perhaps you can take a look at this PR: #5881.

@MiquelRForgeFlow
MiquelRForgeFlow merged commit 367eeea into OCA:19.0 Aug 31, 2026
7 checks passed
@carlos-lopez-tecnativa
carlos-lopez-tecnativa deleted the 19.0-ou-add-stock_landed_costs branch August 31, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants