Fix bot thrashing when attack destination has no upcoming cover - #2113
Merged
sunzenshen merged 1 commit intoSep 5, 2026
Conversation
AdamTadeusz
approved these changes
Sep 4, 2026
sunzenshen
force-pushed
the
bot-attack-fix-no-cover-between-dest-causes-thrash
branch
from
September 5, 2026 01:07
825c836 to
4e4f660
Compare
Contributor
|
This one's gonna' take me a bit more time, likely tomorrow AM. 😭 |
sunmachine
self-requested a review
September 5, 2026 02:04
sunmachine
approved these changes
Sep 5, 2026
sunzenshen
deleted the
bot-attack-fix-no-cover-between-dest-causes-thrash
branch
September 6, 2026 19:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bots could enter a behavior transition trashing state where they attempt to plot an attack path towards a destination but then bounce in and out of the attack behavior transition, because there was no cover between the bot and that location. This would especially happen if the bot's destination was in view. This change causes the bots to fall back to chasing the enemy if there is no suitable cover candidate.
Toolchain