Skip to content

fix(android/v8): skip the ES module cleanup the Android build does not link #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ammarahm-ed wants to merge 1 commit into from
Open

fix(android/v8): skip the ES module cleanup the Android build does not link #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NativeScript/napi/v8/jsr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,9 @@ napi_status js_free_runtime(jsr_ns_runtime runtime) {
v8::Locker locker(jsr->isolate);
// The ES module cache holds thread-local Globals per isolate. Release them
// now; left to thread exit, they would be reset against a disposed isolate.
#ifndef __ANDROID__
v8impl::CleanupESModuleSystem(jsr->isolate);
#endif
while (v8::Isolate::GetCurrent() == jsr->isolate) {
jsr->isolate->Exit();
}
Expand Down
Loading