[ammarahm-ed]

The Android V8 runtime with the Node-API layer no longer links on main:

ld.lld: error: undefined symbol: v8impl::CleanupESModuleSystem(v8::Isolate*)

#118 made js_free_runtime call CleanupESModuleSystem, which lives in vendor/v8/v8-module-loader.cpp. Only the Apple build compiles that file. Android's runtime/CMakeLists.txt builds v8-api.cpp and jsr.cpp only, and Android has no ES module cache to clean up. The call is now compiled out on Android.

	Before	After
./gradlew :app:assembleRelease -Pengine=V8 -PbindingLayer=napi	link error	builds

This is the base of the JNI bridge stack. Every PR above it needs a V8 Node-API build for its numbers.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: fde90548-4c9a-4a1e-91fb-ccd11c6d7fe3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn