Conversation
Use legal status contexts and require explicit test and final job success. Classify the diff with the immutable trusted base instead of executing PR Python. Preserve cleanup after partial provisioning failures and cover poisoned heads, status outcomes, and cleanup behavior. This bounded repair does not claim the existing GPU runner migration or hardware provisioning is complete. Signed-off-by: Joshua Calafato <jcalafato@nvidia.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
11 tasks
chaofengw-nv
added a commit
to chaofengw-nv/TensorRT-Model-Connect-fork
that referenced
this pull request
Sep 11, 2026
Run both stages in one ordered workflow so GPU provisioning begins only after the CPU aggregate passes. Carry forward trusted-base impact classification, fail-closed status publication, exact-merge validation, and deterministic Brev cleanup. Refs: NVIDIA#1255, NVIDIA#1261 Signed-off-by: chaofengw <chaofengw@nvidia.com>
11 tasks
chaofengw-nv
added a commit
to chaofengw-nv/TensorRT-Model-Connect-fork
that referenced
this pull request
Sep 11, 2026
Run both stages in one ordered workflow so GPU provisioning begins only after the CPU aggregate passes. Carry forward trusted-base impact classification, fail-closed status publication, exact-merge validation, and deterministic Brev cleanup. Refs: NVIDIA#1255, NVIDIA#1261 Signed-off-by: chaofengw <chaofengw@nvidia.com>
chaofengw-nv
added a commit
to chaofengw-nv/TensorRT-Model-Connect-fork
that referenced
this pull request
Sep 11, 2026
Introduce a single exact-merge pipeline that authorizes GPU work only after the CPU aggregate succeeds. Preserve the CPU-gated run-internal-ci label bridge and retain the standalone CPU workflow only for rollout compatibility. Run explicit family-owned premerge E2E with native artifacts, staged checkpoints, fail-closed status and cleanup, and repository-wide GPU serialization. Refs: NVIDIA#1255 Refs: NVIDIA#1261 Signed-off-by: chaofengw <chaofengw@nvidia.com>
chaofengw-nv
added a commit
to chaofengw-nv/TensorRT-Model-Connect-fork
that referenced
this pull request
Sep 11, 2026
Introduce a single exact-merge pipeline that authorizes GPU work only after the CPU aggregate succeeds. Preserve the CPU-gated run-internal-ci label bridge and retain the standalone CPU workflow only for rollout compatibility. Run explicit family-owned premerge E2E with native artifacts, staged checkpoints, fail-closed status and cleanup, and repository-wide GPU serialization. Keep the hardened CPU image capable of executing embedded workflow shell regressions, including their jq dependency. Refs: NVIDIA#1255 Refs: NVIDIA#1261 Signed-off-by: chaofengw <chaofengw@nvidia.com>
chaofengw-nv
added a commit
to chaofengw-nv/TensorRT-Model-Connect-fork
that referenced
this pull request
Sep 11, 2026
Introduce a single exact-merge pipeline that authorizes GPU work only after the CPU aggregate succeeds. Preserve the CPU-gated run-internal-ci label bridge and retain the standalone CPU workflow only for rollout compatibility. Run explicit family-owned premerge E2E with native artifacts, staged checkpoints, fail-closed status and cleanup, and repository-wide GPU serialization. Keep the hardened CPU image capable of executing embedded workflow shell regressions, including their jq dependency. Carry the live Brev Docker permission fix by using sudo on freshly reserved instances. Refs: NVIDIA#1255 Refs: NVIDIA#1261 Refs: NVIDIA#1264 Signed-off-by: chaofengw <chaofengw@nvidia.com>
chaofengw-nv
added a commit
to chaofengw-nv/TensorRT-Model-Connect-fork
that referenced
this pull request
Sep 11, 2026
Introduce a single exact-merge pipeline that authorizes GPU work only after the CPU aggregate succeeds. Preserve the CPU-gated run-internal-ci label bridge and retain the standalone CPU workflow only for rollout compatibility. Run explicit family-owned premerge E2E with native artifacts, staged checkpoints, fail-closed status and cleanup, and repository-wide GPU serialization. Keep the hardened CPU image capable of executing embedded workflow shell regressions, including their jq dependency. Carry the live Brev Docker permission fix by using sudo on freshly reserved instances. Refs: NVIDIA#1255 Refs: NVIDIA#1261 Refs: NVIDIA#1264 Signed-off-by: chaofengw <chaofengw@nvidia.com>
chaofengw-nv
added a commit
to chaofengw-nv/TensorRT-Model-Connect-fork
that referenced
this pull request
Sep 11, 2026
Introduce a single exact-merge pipeline that authorizes GPU work only after the CPU aggregate succeeds. Preserve the CPU-gated run-internal-ci label bridge and retain the standalone CPU workflow only for rollout compatibility. Run explicit family-owned premerge E2E with native artifacts, staged checkpoints, fail-closed status and cleanup, and repository-wide GPU serialization. Keep both public and protected hardened CPU images capable of executing embedded workflow shell regressions, including their jq dependency. Carry the live Brev Docker permission fix by using sudo on freshly reserved instances. Refs: NVIDIA#1255 Refs: NVIDIA#1261 Refs: NVIDIA#1264 Signed-off-by: chaofengw <chaofengw@nvidia.com>
chaofengw-nv
added a commit
that referenced
this pull request
Sep 11, 2026
Introduce a single exact-merge pipeline that authorizes GPU work only after the CPU aggregate succeeds. Preserve the CPU-gated run-internal-ci label bridge and retain the standalone CPU workflow only for rollout compatibility. Run explicit family-owned premerge E2E with native artifacts, staged checkpoints, fail-closed status and cleanup, and repository-wide GPU serialization. Keep both public and protected hardened CPU images capable of executing embedded workflow shell regressions, including their jq dependency. Carry the live Brev Docker permission fix by using sudo on freshly reserved instances. Refs: #1255 Refs: #1261 Refs: #1264 Signed-off-by: chaofengw <chaofengw@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Community GPU CI is rejected before jobs start because its shell script interpolates
failure()in an unsupported expression context. Review also found that impact classification checked out and executed pull-request code on the trusted orchestration runner, mixed diagnostic text with JSON, and could report incomplete tests as successful.This isolated repair addresses workflow syntax, trusted classification, status reporting and cleanup. It deliberately does not claim to finish the separate GPU execution migration.
Exit Criteria
Implementation
tools.test_impactCLI with base/head diff operands, without checking out or importing PR code. Parse its pure JSON output separately from action outputs. New families absent from the trusted inventory conservatively select all trusted families.Change categories
Validation
Commands and Results
"$TEST_PYTHON" -m pytest -q tools/tests/test_community_ci.py tools/tests/test_family_impact.py tools/tests/test_architecture.py: 101 passed./tmp/trtmc-actionlint-1.7.12/actionlint -shellcheck= -pyflakes=: passed for all workflows. This validates workflow expressions/schema; optional ShellCheck/Pyflakes integrations were disabled because they are not installed.tools/tests/test_community_ci.pyrun: 36 passed, including actual shell-step execution with fake service clients and isolated Git fixtures.git diff --check: passed.f6ec6b3aa8fad4cd973508097d08fbf7daaa040e, including source quality, ownership, docs, hardened units and Required aggregate.Hardware, Environment, and Revisions
f6ec6b3aa8fad4cd973508097d08fbf7daaa040e; base:a50cf5dc215e84c1d9341a8ef72f7df746bde894.Not Run / Remaining Gaps
The existing GPU runner still needs a faithful family-owned E2E setup:
tests/e2e/models/{family}paths with the existing family-owned tests.py-onlyinstall is insufficient.No smoke-family substitution, large-test filtering, quantization workaround or threshold reduction is included. Syntax/contract validation is not evidence of a successful GPU smoke run.
Contributor Self-Review
Independent review approved the bounded syntax, trust, status and cleanup repair. Actual GPU execution readiness remains unresolved and explicitly outside the validation claim.
Notes For Future Readers
Review the trusted checkout/classifier first, then fail-closed status publication and cleanup, followed by the poison-head/outcome regressions. Do not reintroduce a PR-head checkout on the trusted runner or treat missing test output as success.
This repair is separate from the Edge adapter feature in #1253. Its workflow must enter trusted
mainthrough normal reviewed merge rules before it can affect the default-branch dispatcher; no direct-main push or check bypass is intended. Keep this PR draft until runner setup and resource policy are resolved.Risk level
The diff is bounded and improves the trust boundary, but it changes orchestration that can allocate paid GPU resources. Local tests do not validate the external service or real model execution.