Conversation
Provision pinned native Edge-LLM through optional CMake infrastructure. Let Qwen3.5 and Qwen3.8 own configuration/platform dispatch and thin builder/runtime API adapters, with warning and one native retry after builder failure. Add family-local contract and real inference validation. Keep legacy Qwen unchanged and document unqualified configurations and the architecture checks awaiting maintainer review. Signed-off-by: Joshua Calafato <jcalafato@nvidia.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
Keep the closed CMake inventory explicit for Edge provisioning. Follow bounded family-local request and invoked callback handling without crediting dead, shadowed, foreign or unrelated helpers. Preserve the mandatory field set and cover positive and negative delegation cases. Signed-off-by: Joshua Calafato <jcalafato@nvidia.com>
11 tasks
|
Please add more model to the dispatch logic since we have seen more Edge-LLM supported model being reimplemented here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Newer Qwen families should reuse Edge-LLM when the checkpoint, build request and executing platform are supported. This adds automatic complete-network delegation while keeping ownership and failure isolation inside each family.
Exit Criteria
Implementation
main()and persistentLLMInferenceRuntimeAPIs. Ordinary Edge preparation failure warns, retains diagnostics and retries native once with the unchanged request. Publication errors, cancellation and inference errors do not silently switch backends.find_package/ExternalProjectprovisioning installs Edge v0.10.1 at an immutable commit. Cross compilation is rejected.BundleReader::copy_sectionsupport the integration. Family markers/assets identify Edge bundles; the existing task ABI and core bundle-format version remain unchanged.Change categories
Validation
Commands and Results
Architecture-only follow-up, candidate head
05700b6f25544e1126db4ad4ae903b774c3c44f9:"$TEST_PYTHON" -m pytest -q tools/tests/test_architecture.py: 74 passed.python -m tools.community_ci source-quality --base github/main: passed, including 157 contract tests, using pinned Ruff 0.16.4, clang-format 22.1.8 and lizard 1.21.2.python -m tools.community_ci unitin a standalone exact-head checkout: passed. 447 Python tests passed, all 1,210 C++ build steps completed, and CTest finished successfully (142 passed, 6 skipped in the GPU-free container). The initial worktree-mounted attempt failed only because its external Git metadata was outside the container; no test criteria were changed.05700b6f25544e1126db4ad4ae903b774c3c44f9, including source quality, docs, ownership, units and Required aggregate. DCO and PR Metadata also passed.Implementation/hardware evidence at
42cdea6c137839741443c9794610321fcfa59d8d, before the test-only follow-up:"$QUALIFICATION_PYTHON" -m pytest -q core/builder/tests families/qwen3_5/tests families/qwen3_8/tests -m "not e2e and not gpu and not trt": 261 passed, 2 skipped.ctest --test-dir /tmp/newer-edge-runtime --output-on-failure -R "edge|bundle_format": 8 passed, after rebuilding both family runtimes, validation drivers and bundle/adapter contracts.Passed: automatic Edge build; exact Model Connect/direct-Edge greedy token/text parity; raw/chat/EOS; unsupported-control and capacity rejection; persistent repeat after rejection; unchanged family quality criteria against an independently generated CPU FP32 HF reference. The harness rejects native fallback bundles. These hardware results are not a fresh run on the test-only follow-up head. No performance qualification is claimed.
Hardware, Environment, and Revisions
05700b6f25544e1126db4ad4ae903b774c3c44f9; base:a50cf5dc215e84c1d9341a8ef72f7df746bde894. Hardware proof head:42cdea6c137839741443c9794610321fcfa59d8d.Qwen/Qwen3.5-0.8B:2fc06364715b967f1860aea9cf38778875588b17.e8b29522938901f6df19ebeedd4b69bc8edbcd97. Its package, all 28 FMHA/GDN AOT variants and separate-prefix installation were validated before the hardware-proof rebase; the installed package was reused withCMAKE_PREFIX_PATH=/tmp/trtmc-edge-native-install.Not Run / Remaining Gaps
05700b6f25544e1126db4ad4ae903b774c3c44f9; public CPU has passed. No protected premerge pass is claimed.Contributor Self-Review
Manual and independent reviews covered family ownership, fallback boundaries, direct upstream APIs, validation evidence and conservative architecture-test attribution. Required exact-head CI remains the draft readiness gate.
Notes For Future Readers
Review CMake provisioning, family dispatch/build mapping, bounded streaming, then family runtime/tests and architecture regressions. Suggested reviewers: @yifeif-nv, @chaofengw-nv and @xuanzic.
Edge support is optional at CMake configuration time and automatic at model build time. Bundles retain the selected implementation and require a matching native SDK/platform at inference. Update the pin and rebuild artifacts together; model-specific orchestration must remain family-owned. Family documentation includes setup and reproduction without the precomputed HF report.
Risk level
Optional provisioning limits exposure, but package compatibility and complete-network delegation span build/runtime boundaries. The test-only follow-up changes no production behavior or model acceptance threshold.