Skip to content

build(rocm): publish Genesis optional profile - #2532

Merged
TATP-233 merged 1 commit into
mainfrom
fix/issue-2531-rocm-genesis-extra
Oct 26, 2026
Merged

TATP-233 merged 1 commit into
mainfrom
fix/issue-2531-rocm-genesis-extra

Conversation

@TATP-233

Copy link
Copy Markdown
Collaborator

Summary

  • Add the pinned genesis-world==1.3.3 optional extra to the ROCm project profile.
  • Regenerate uv.rocm.lock so that optional ROCm Genesis installs resolve from registry packages.
  • Keep make sync-rocm minimal: it continues to install only the mujoco extra by default. Genesis and Motrix remain opt-in backend installations.
  • Add a focused profile test keeping the default and ROCm Genesis extras aligned.

Linked Work

Validation

  • make test-all passed on the final local head before this PR was created or updated
  • Additional task-specific validation listed below

Commands actually run:

make -n sync-rocm
# Confirmed default remains: uv sync --extra mujoco

uv run pytest tests/scripts/test_rocm_dependency_profile.py -q
# 5 passed

# Temporarily select pyproject.rocm.toml/uv.rocm.lock, then:
uv lock --check --no-progress
# Resolved 231 packages; lock is up-to-date
# Restored and verified pyproject.toml/uv.lock unchanged

git diff --check
# PASS

make test-all
# check/type gates passed
# 2829 passed, 61 skipped, 374 deselected, 18 warnings
# benchmark import smoke: 35/35 module mode, 36/36 script mode

Remote CI route:

  • Base main: current-head CI link and status recorded below after GitHub starts the run.

Impact

  • Backend impact: genesis dependency metadata only; no runtime backend code change
  • Platform impact: Linux / ROCm dependency profile
  • Training effect expected: no

Artifacts

  • W&B: not applicable
  • benchmark result: not applicable
  • video / screenshot: not applicable
  • ONNX / checkpoint: not applicable

Checklist

  • Added or updated tests where needed
  • Updated docs if behavior or workflow changed
  • Linked the driving issue
  • Noted any follow-up work explicitly

Runtime ROCm SAC/Genesis stability remains tracked separately in #2530; this PR only publishes the optional dependency profile.

@TATP-233
TATP-233 merged commit 7740353 into main Oct 26, 2026
8 of 9 checks passed
@TATP-233
TATP-233 deleted the fix/issue-2531-rocm-genesis-extra branch October 26, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant