Repository navigation
feat(genesis): support ROCm collector runtime - #2519
Merged
TATP-233 merged 8 commits intoOct 26, 2026
Merged
Conversation
TATP-233
changed the base branch from
main
to
dev/issue-2520-genesis-dr-lifecycle
October 26, 2026 10:23
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
torch_runtime_familyplusgenesis_backendrocm-smiwhile preserving the NVIDIAnvidia-smipathRefs unilabsim/unisim#471
This PR also carries the six #457 collector-benchmark commits because that integration is not yet in
main; the issue #471 commit is677b709a.Benchmark evidence
torch_runtime_family=rocm,genesis_backend=amdgpu, and driver6.19.14.31400000; the CUDA artifact recordstorch_runtime_family=cuda,genesis_backend=cuda, and driver580.178.04.Validation
make check— passed.make test-all— 2811 passed, 61 skipped, 373 deselected; benchmark smoke 35/35 module-mode and 36/36 script-mode passed.Integration note
Current CI resolves the published
unisim-core==2.1.1, which does not yet contain the Genesis ROCm profile. The ROCm preflight and generated-matrix checks therefore require the UniSim change to land in a released package. Final-head local validation used the matching UniSim source throughPYTHONPATH; no local-path dependency or unpublished dependency pin is committed. UniSim PR: unilabsim/unisim#473.