Skip to content

chore(genesis): remove ROCm investigation scaffolding - #2525

Merged
TATP-233 merged 1 commit into
dev/issue-2520-genesis-dr-lifecyclefrom
cleanup/issue-471-genesis-rocm
Oct 26, 2026
Merged

TATP-233 merged 1 commit into
dev/issue-2520-genesis-dr-lifecyclefrom
cleanup/issue-471-genesis-rocm

Conversation

@TATP-233

Copy link
Copy Markdown
Collaborator

Summary

  • Removes the temporary feat: enable Sharpa Inhand Rotation training with Motrix backend #457 collector benchmark and attribution scaffolding that was used to reach the Genesis ROCm conclusion.
  • Keeps the durable Genesis ROCm enablement already on the base: the UniSim-profile-owned HIP gate, exact CUDA/ROCm runtime documentation, platform tests, AMDGPU fake-runtime coverage, and the existing event-backed Genesis completion-receipt declaration.
  • Removes the benchmark-only EnvCfg knob, read-plan attribution API, timing schema additions, runtime benchmark module/schema, production benchmark documentation, and benchmark script/test expansions. This restores the public runtime interfaces to their pre-investigation shape.
  • No vendor-specific collector hot path is introduced; Genesis continues to use the same DEVICE_RESIDENT / IN_PROCESS / DIRECT lifecycle through UniSim.

Linked Work

  • Issue: unilabsim/unisim#471
  • Follow-up to Motphys/UniLab#2519
  • Parent roadmap: not applicable
  • Roadmap declared base: not applicable
  • Milestone: not applicable
  • Base branch: dev/issue-2520-genesis-dr-lifecycle

Validation

  • make test-all passed on the final local head before this PR was created or updated
  • Additional task-specific validation listed below

Commands actually run:

make check
# passed: ruff, mypy, pyright, and focused test lint

uv run pytest -q \
  tests/base/test_cuda_backend_platform_preflight.py \
  tests/base/test_genesis_backend.py \
  tests/base/test_entity_tensor_read_plan.py \
  tests/base/test_torch_env.py \
  tests/benchmark/test_offpolicy_collector_active_benchmark.py
# 124 passed, 12 warnings

make test-all
# check passed
# 2824 passed, 62 skipped, 373 deselected, 24 warnings
# benchmark import smoke: module-mode 35/35, script-mode 36/36

Remote CI route:

  • Base main: not applicable.
  • Any other base: not scheduled; local make test-all is the test gate.

Impact

  • Backend impact: genesis
  • Platform impact: Linux
  • Training effect expected: no; this removes investigation instrumentation while retaining the Genesis ROCm training path

Artifacts

Checklist

  • Added or updated tests where needed
  • Updated docs if behavior or workflow changed
  • Linked the driving issue
  • Noted any follow-up work explicitly

@TATP-233
TATP-233 merged commit c64fbe7 into dev/issue-2520-genesis-dr-lifecycle Oct 26, 2026
@TATP-233
TATP-233 deleted the cleanup/issue-471-genesis-rocm branch October 26, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant