fix: warn when fd is missing outside git repos#290
Open
Eric-Song-Nop wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: e0114d4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Author
|
@liruifengv 实际上真正在pi agent中的做法是,https://github.com/earendil-works/pi/blob/335e09ba0d12ddb3f169ca323df0bef0fd61cc48/packages/coding-agent/src/utils/tools-manager.ts#L326 保证了 |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Related to #266
Problem
When
fdis not installed,@file completion still works inside git repositories through the existing git fallback, but outside git repositories it may not return candidates. That failure mode was not visible to users.该项目并没有明确
fd应该是一个系统依赖。What changed
这是一个最小警告,我在系统中没有
fd且不在git项目中启动kimi code是进行了最小化警报。The TUI now shows a startup warning only when
fdis missing and the current directory is not a git repository. Git repositories stay quiet because the existinggit ls-filesfallback remains available.Added startup tests covering missing
fdin git and non-git directories, plus thefd-available path.Validation:
corepack pnpm exec vitest run apps/kimi-code/test/tui/kimi-tui-startup.test.ts apps/kimi-code/test/tui/components/editor/file-mention-provider.test.ts apps/kimi-code/test/utils/git/git-ls-files.test.tscorepack pnpm --filter @moonshot-ai/kimi-code run typecheckcorepack pnpm exec oxlint --type-aware apps/kimi-code/src/tui/kimi-tui.ts apps/kimi-code/test/tui/kimi-tui-startup.test.tsgit diff --checkChecklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.