Skip to content

[706] ensure goldfish has the same macro definition as s7 #3671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JimZhouZZY wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

[706] ensure goldfish has the same macro definition as s7 #3671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions devel/706.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# What
在 goldfish 的构建过程中保证与 s7 的宏定义一致。目前的定义过程相较于 s7 的 xmake.lua 少了一个条件，导致二者不一致。

# Why
目前的定义方式在 wasm 平台会与 s7 不一致导致出错
4 changes: 3 additions & 1 deletion xmake/goldfish.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@ target ("goldfish") do
})

add_defines("WITH_SYSTEM_EXTRAS=0")
add_defines("HAVE_OVERFLOW_CHECKS=0")
if not is_plat("wasm") then
add_defines("HAVE_OVERFLOW_CHECKS=0")
end
add_defines("WITH_WARNINGS")
add_defines("WITH_R7RS=1")
if is_mode("debug") then
Expand Down