[706] ensure goldfish has the same macro definition as s7#3671
Open
JimZhouZZY wants to merge 1 commit into
Open
[706] ensure goldfish has the same macro definition as s7#3671JimZhouZZY wants to merge 1 commit into
JimZhouZZY wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
在 goldfish 的构建过程中保证与 s7 的宏定义一致。目前的定义过程相较于 s7 的 xmake.lua 少了一个条件，导致二者不一致。
Why
目前的定义方式在 wasm 平台会与 s7 不一致导致出错