Repository navigation
perf(cache): make CPU cache reads and writes asynchronous #1683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
WANDY666
wants to merge
3
commits into
main
Choose a base branch
from
perf/cpu-cache-async-io
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script executed:
rg -n 'def init_flashmla_prefill_q|flashmla_prefill_q|def _init_att_backend|initialize_storage' lightllm/models/deepseek_v4 lightllm/server/router/model_infer/mode_backend/base_backend.pyRepository: ModelTC/LightLLM
Length of output: 1209
Script executed:
Repository: ModelTC/LightLLM
Length of output: 39301
Script executed:
Repository: ModelTC/LightLLM
Length of output: 42491
Script executed:
Repository: ModelTC/LightLLM
Length of output: 18887
Web query:
torch_memory_saver 0.0.9.post1 region enable_cpu_backup pause resume contentsResult:
Script executed:
Repository: ModelTC/LightLLM
Length of output: 18220
Keep DeepSeek-V4 workspace allocation outside the KV-cache region.
When CPU cache is enabled,
_init_att_backend()createsflashmla_prefill_qinside theMemoryTag.KV_CACHEregion. A KV-cache pause discards this buffer's contents. After resume, the prefill path rewrites only the local query heads and passes the padded heads toprefill_att. This can produce incorrect resumed prefill results because the padded heads are no longer zeroed.Keep backend construction before
manager.initialize_storage, but run it outside the KV-cache region. Keep CPU-cache backend configuration inside that region.Suggested fix
Ruff (0.17.0)
[warning] 174-174: Comment contains ambiguous
;(FULLWIDTH SEMICOLON). Did you mean;(SEMICOLON)?(RUF003)
[warning] 174-174: Comment contains ambiguous
,(FULLWIDTH COMMA). Did you mean,(COMMA)?(RUF003)