Skip to content

fix: resolve @metamask/snap-networks-utils to source for typechecking - #171

Merged
ulissesferreira merged 2 commits into
mainfrom
ulissesferreira/tsconfig-baseurl-references-paths
Aug 19, 2026
Merged

fix: resolve @metamask/snap-networks-utils to source for typechecking#171
ulissesferreira merged 2 commits into
mainfrom
ulissesferreira/tsconfig-baseurl-references-paths

Conversation

@ulissesferreira

@ulissesferreira ulissesferreira commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Fixed silent dist fallback in typechecking: added the missing baseUrl to stellar-wallet-snap/tron-wallet-snap and TypeScript project references from bitcoin/solana/tron-wallet-snap to snap-networks-utils, so cross-package imports resolve to live source instead of silently falling back to potentially-stale published dist declarations.
  • Simplified the shared paths config: migrated all 69 @metamask/snap-networks-utils/logger imports to the package's main entry point (which already re-exports Logger/LogLevel), letting the generic @metamask/* wildcard handle resolution on its own — no per-subpath paths entry needed.
  • Removed dead config: dropped the unused "examples/*" workspaces glob from the root package.json (no such directory exists in the repo).

@ulissesferreira
ulissesferreira requested review from a team as code owners August 19, 2026 13:13
@ulissesferreira
ulissesferreira deployed to default-branch August 19, 2026 13:14 — with GitHub Actions Active
ulissesferreira
ulissesferreira commented Aug 19, 2026
View reviewed changes
Comment thread package.json
"url": "https://github.com/MetaMask/internal-snaps.git"
},
"workspaces": [
"examples/*",

@ulissesferreira ulissesferreira Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@ulissesferreira ulissesferreira changed the title fix: resolve @metamask/snap-networks-utils to source for typechecking fix: resolve @metamask/snap-networks-utils to source for typechecking Aug 19, 2026
@ulissesferreira
ulissesferreira force-pushed the ulissesferreira/tsconfig-baseurl-references-paths branch from f7e01a2 to b1236b5 Compare August 19, 2026 13:39
@ulissesferreira
chore: remove typecheck script
988cb97 
Not wired into CI, and its manual pre-build of snap-networks-utils
was working around the resolution gap the previous commit fixes.
@ulissesferreira
ulissesferreira added this pull request to the merge queue Aug 19, 2026
Merged via the queue into main with commit 3d22bc6 Aug 19, 2026
52 checks passed
@ulissesferreira
ulissesferreira deleted the ulissesferreira/tsconfig-baseurl-references-paths branch August 19, 2026 13:56
@ulissesferreira ulissesferreira mentioned this pull request Aug 19, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikesposito mikesposito mikesposito approved these changes

Assignees

No one assigned

Labels

no-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ulissesferreira @mikesposito