chore: remove dead MetaMask/core-specific rules from eslint.config.mjs - #172
Merged
Merged
Conversation
ulissesferreira
changed the title
ulissesferreira
marked this pull request as ready for review
August 19, 2026 13:58
This config was bootstrapped from MetaMask/core and still targeted packages that don't exist in this repo (foundryup, messenger, messenger-cli, notification-services-controller, assets-controllers and friends, wallet-framework-docs), plus a few dead glob entries (.docusaurus, merged-packages/**, docusaurus.config.ts) with no matching files.
ulissesferreira
force-pushed
the
cleanup/eslint-config-dead-rules
branch
from
August 19, 2026 13:59
f55eff4 to
058eb58
Compare
ulissesferreira
changed the title
MetaMask/core-specific rules from eslint.config.mjs
ulissesferreira
commented
Aug 19, 2026
| '**/dist/**', | ||
| '**/docs/**', | ||
| '.yarn/**', | ||
| 'merged-packages/**', |
Contributor
Author
There was a problem hiding this comment.
I don't think we will need this no more because no more packages to migrate
taran-a
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
eslint.config.mjswas originally bootstrapped fromMetaMask/coreand still contained several config blocks targeting packages that only exist incore, never trimmed for this repo. Verified each of these paths has zero matches ininternal-snaps(only 6 packages exist here:bitcoin-wallet-snap,sample-snap,snap-networks-utils,solana-wallet-snap,stellar-wallet-snap,tron-wallet-snap).Removed:
filesblocks forpackages/foundryup/**,packages/messenger/src/generate-action-types/**,packages/messenger-cli/src/**,packages/notification-services-controller/**, the 14-fileassets-controllers/controller-utils/ens-controller/etc. list, andpackages/wallet-framework-docs/site/docusaurus.config.ts— none of these paths exist in this repo.**/.docusaurusandmerged-packages/**fromignores, and**/docusaurus.config.tsfrom the Node files list (no docusaurus site exists here).Validation
yarn eslint .passes with exit 0 (config still loads and lints correctly after removal).yarn buildpasses for all packages.References
@metamask/snap-networks-utilsto source for typechecking #171