Repository navigation
fix(transform): smooth sampling uses no edge margins, so the Start corner click works (#393) - #394
Merged
Merged
Conversation
…rner click works (#393) Both the low-side edge margin and the right/bottom TDR margin keep desktop texels out of the zoomed view, and the pointer-framework hit-test ignores a pointer outside it: zoomed, the bottom-left corner click never reached Start. Both margins defend the nearest path only. Smooth sampling now uses native Magnifier's exact rect (0 and 0); nearest keeps 1 and 2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011zPmivSAQeivGUdBjTsaMu
The input-transform publish used the unclamped source rounded to nearest, while the visual write floors at the far edge (and the 16-bit backstop can move it further), so hover hit-testing sat up to a source pixel off along the right/bottom edge. Publish the offsets actually written. Review of #394. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011zPmivSAQeivGUdBjTsaMu
# Conflicts: # src/hook_transform.cpp # src/hook_transform.h # src/main.cpp
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011zPmivSAQeivGUdBjTsaMu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #393.
Problem
Zoomed, a click in the bottom-left corner did not open Start. Unzoomed it does, and native Magnifier opens it at 2x, 3x, 11x and 16x.
Cause
Two margins keep desktop texels out of the zoomed view:
txEdgeMargin=1, left/top);ComputeMagTransform(Game zoom perf: zooming over a game halves fps with periodic multi-hundred-ms spikes #148).The pointer-framework hit-test ignores a pointer outside the view, so the corner pixel was dead. Field probes on 2026-10-09: either margin alone kills the corner; both at 0 fix it. Native's rect always reaches column 0 and row 2160.
Fix
EdgeMarginsFor(samplingMode, txEdgeMargin)picks the margins:Used by the tick writer and the hook writer.
Tests
EdgeMarginsForand the corner pixel at 2x to 16x.Note: when #388 merges, it deletes
hook_transform.*; the hook hunks here then drop.🤖 Generated with Claude Code
https://claude.ai/code/session_011zPmivSAQeivGUdBjTsaMu