Repository navigation
fix(transform): no edge margins for sharp zoom either, so the Start corner works - #433
Merged
Merged
Conversation
…orner works; 0.26.1 Nearest sampling dropped its 1 texel low and 2 px far margins (#244, #148) after a clean field test: the Start corner click works while zoomed, no grey edge line, no driver reset. txEdgeMargin now defaults to 0; setting it to 1 brings both nearest margins back as a kill switch. Closes #432 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011zPmivSAQeivGUdBjTsaMu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #432
What
Sharp (nearest) zoom drops its edge margins, like smooth zoom did in #394: the view now covers the whole desktop, so a click in the bottom-left corner opens Start while zoomed.
EdgeMarginsForreturns 0/0 unlesstxEdgeMarginis above 0.txEdgeMargindefaults to 0. Setting it to 1 is the kill switch: nearest gets the 1 texel low margin (Grey vertical line down the left edge of the magnified view (and its twin along the top) #244 grey line) and the 2 px far margin (Game zoom perf: zooming over a game halves fps with periodic multi-hundred-ms spikes #148 reset guard) back.txSharpMarginsswitch from the field build is gone.Why
Field test 2026-10-10 on the build with the margins dropped: Start corner works, no grey line, no driver reset, games included. The 16-bit overflow the far margin partly guarded now has its own guards (pan walls, MPO nearest guard, write-site clamp).
Tests
build.bat test: 603 passed, 0 failed (new: default margins are 0/0; the bottom-left corner pixel is inside the view with default nearest margins at 2x to 16x).build.bat: app builds clean.status=Valid).Version: 0.26.0 -> 0.26.1 (fix). Release unsigned as before.
🤖 Generated with Claude Code
https://claude.ai/code/session_011zPmivSAQeivGUdBjTsaMu