Skip to content

fix(pr-review): bind the GitHub App slug on maple-ai so reviews mention the real bot - #1166

Merged
Makisuo merged 1 commit into
mainfrom
fix/pr-review-bot-mention-slug
Sep 29, 2026
Merged

Makisuo merged 1 commit into
mainfrom
fix/pr-review-bot-mention-slug

fix(pr-review): bind the GitHub App slug on maple-ai so reviews menti…

4e4afbf
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Sep 29, 2026 in 30s

Confidence 5/5 · No issues found

🟢 Confidence 5/5 · safe to merge
One key moved between two deploy-time groups; api still binds it through githubAppSourceEnv, so only maple-ai gains a binding.
quality 100/100 · no findings · tests not needed · risk low

Moves GITHUB_APP_SLUG from api's own env list into the shared githubAppSourceEnv group, so maple-ai — which publishes PR reviews — binds the App slug and reviewerMention stops falling back to @maple. Safe to merge.

  • githubAppSourceEnv now binds GITHUB_APP_SLUG alongside app id and key
  • apps/api drops its own api-only optionalPlain("GITHUB_APP_SLUG")
What was checked
  • api keeps the slug: apiConfiguredEnv still spreads githubAppSourceEnv (apps/api/src/resources/env.ts:107)
  • reviewerMention (packages/domain/src/http/pr-review.ts:739) trims the slug and falls back on empty, so a blank binding is safe
  • maple-ai's configuredEnv already spreads githubAppSourceEnv (apps/ai/src/worker.ts:123), so alchemy binds the new key there

4e4afbf · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple to ask about one.