Skip to content

fix(pr-review): bind the GitHub App slug on maple-ai so reviews mention the real bot - #1166

Merged
Makisuo merged 1 commit into
mainfrom
fix/pr-review-bot-mention-slug
Sep 29, 2026
Merged

Makisuo merged 1 commit into
mainfrom
fix/pr-review-bot-mention-slug

Conversation

@Makisuo

@Makisuo Makisuo commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

Published reviews still said "mention @maple to ask about one" after #1162.

The review comment is published from the maple-ai Worker, but `GITHUB_APP_SLUG` was only bound on api. On maple-ai the slug was always missing, so `reviewerMention` fell back to `@maple`.

Moves `GITHUB_APP_SLUG` into `githubAppSourceEnv`, which both Workers bind, and drops the api-only copy.

Existing review comments pick up the right handle on the PR's next push.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

…on the real bot

Reviews are published from maple-ai, which only bound the app id and key, so
reviewerMention fell back to @maple on every published review.
@maple-review-bot

maple-review-bot Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Maple review

🟢 Confidence 5/5 · safe to merge
One key moved between two deploy-time groups; api still binds it through githubAppSourceEnv, so only maple-ai gains a binding.
quality 100/100 · no findings · tests not needed · risk low

Moves GITHUB_APP_SLUG from api's own env list into the shared githubAppSourceEnv group, so maple-ai — which publishes PR reviews — binds the App slug and reviewerMention stops falling back to @maple. Safe to merge.

  • githubAppSourceEnv now binds GITHUB_APP_SLUG alongside app id and key
  • apps/api drops its own api-only optionalPlain("GITHUB_APP_SLUG")
What was checked
  • api keeps the slug: apiConfiguredEnv still spreads githubAppSourceEnv (apps/api/src/resources/env.ts:107)
  • reviewerMention (packages/domain/src/http/pr-review.ts:739) trims the slug and falls back on empty, so a blank binding is safe
  • maple-ai's configuredEnv already spreads githubAppSourceEnv (apps/ai/src/worker.ts:123), so alchemy binds the new key there

4e4afbf · Updated on every push. Reply "won't fix" to dismiss a finding, or mention @maple to ask about one.

@coderabbitai

coderabbitai Bot commented Sep 29, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 347b1797-3a75-4ef3-805f-682e0751d9aa

📥 Commits

Reviewing files that changed from the base of the PR and between 11fb6f6 and 4e4afbf.

📒 Files selected for processing (2)
  • apps/api/src/resources/env.ts
  • packages/infra/src/env.ts
 _________________________________________________
< PhD, MSc, BSc, and a black belt in code review. >
 -------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Makisuo
Makisuo merged commit 1d4ab5b into main Sep 29, 2026
35 of 37 checks passed
@Makisuo
Makisuo deleted the fix/pr-review-bot-mention-slug branch September 29, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant