Repository navigation
refactor: own tic-tac-toe source and align saga branding - #5
Conversation
yia-mw-agent
left a comment
There was a problem hiding this comment.
Helmet-Review-Request: #5 (comment)
Reviewed the full merge-base (a1c0970) to head (4a3ba40) diff against main: 55 files, +2798/-253. The head was also the live head at start and before submitting. No material defects.
What I checked:
- The new apps/tic-tac-toe/game tree is the SDK's examples/tic-tac-toe at the previously pinned revision 522d613. I diffed it against that archive: the only differences are the README, saga/Machine Wisdom casing in comments and the package description, and the added test/ directory. Rules, operations, contract, catalog, controller and view are unchanged, which supports the PR's claim that gameplay is unchanged.
- The Worker, Durable Object, store, view entry and browser spec now import from ../game instead of .stage/game. The removed staging and archive-pin scripts (sdk-source.json, sdk-archive.mjs, stage-sdk-source.mjs) leave no remaining references; build-view, check-icons and stage-publication correctly define root locally.
- The workspace entry and package-lock.json agree (workspace link plus the game's exact pinned dependencies, matching the root manifest). Registry versions are unchanged.
- Plugin 0.1.1 is consistent across plugin.json and saga-publication.json. The README keeps the 0.1.0 observation as a marked historical record, and scripts/check-brand.mjs exempts only that one line.
- Dragon icon files are unchanged and their digests match.
Validation at 4a3ba40 (clean npm ci): check-brand and check-icons pass (with the four LFS PNGs materialized from the LFS media endpoint, since this runtime has no git-lfs); typecheck (root, browser and game workspace) passes; test:game 45/45; Workers-runtime vitest 16/16; Chromium card tests 13/13; npm run build Worker dry run succeeds. scripts/check-lfs.py could not run here because git-lfs is not installed. It is part of CI, and no pointer or .gitattributes file changed in this PR.
Non-blocking:
- README.md says the local run needs Node 22.23.3 or newer while the manifests declare >=22.12.0; consider aligning the two.
This review covers source readiness only, not deployment or host acceptance.
The hosted game previously downloaded its implementation from the SDK repository. This change makes this repository the canonical owner: local Node/Vite development and the Worker import one game implementation, while SDK dependencies remain exact registry installs. The SDK tutorial will consume a pinned revision of this application after this PR merges.
It also corrects saga and Machine Wisdom display copy, the accessible dragon label, and plugin 0.1.1 metadata generated through the SDK publication assembler. Artwork, attribution URL, MCP endpoint, Durable Object identity, storage and gameplay are unchanged. The owner approved this source-ownership migration and normal reviewed delivery; no SDK API or package release is involved.
Validation: clean registry npm ci; npm run check (45 game/controller/local-server tests, 16 Workers-runtime tests, 13 Chromium checks, type checks, local Vite build and Worker dry-run); tracked LFS pointers and unchanged icon digests. Source validation does not establish deployment, marketplace synchronization or installed host names. These follow merge.