Repository navigation
chore: move tutorial game ownership to examples - #361
Merged
Merged
Conversation
yia-mw-agent
approved these changes
Oct 30, 2026
yia-mw-agent
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the full merge-base (95c5708) to head (d36d68e) diff against main: 44 files; the SDK game directory and its rules/controller tests removed, the pinned external-source staging added, and the docs, blueprints and brand copy updated.
No material defects.
Evidence at d36d68e:
npm run stage:tutorialdownloaded the examples archive at 6431e6a, verified the decompressed SHA-256 againstscripts/tic-tac-toe-source.json, and stagedapps/tic-tac-toe/game(the--strip-components=4path is right). Changed bytes, bad gzip and an invalid pin are rejected before extraction, and the cache is written only after verification.- vitest on the stage, document, boundary, stack-imports, tic-tac-toe and guide tests: 6 files, 148 tests passed. This includes the candidate build and typecheck of all three tutorial checkpoints against packed SDK packages.
- Root
tsc -p tsconfig.jsonand the lit-host typecheck pass. The remaining references toexamples/tic-tac-toeare only the negative assertion inscripts/tic-tac-toe.test.ts. build-tic-tac-toe.tsagainst the staged source succeeded, ande2e/tic-tac-toe.spec.tsran in Chromium (lit project): 27 passed.- Prettier check on the changed files passes. At review time the Version policy, documentation and advisory-lint CI jobs passed. The "Application types, builds, tests and release qualification" job was still pending, so I did not rely on it.
Non-blocking notes:
stageTutorialGamereads a cached archive without a size bound; it is verified by digest, so this is only a robustness observation..version-policy.jsonnow lists the two staging files as development paths; this matches the PR's no-version-bump claim.
Helmet-Review-Request: #361 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tic-tac-toe application now lives in saga-a2ui-examples, shared by its local Node/Vite build and hosted Worker. This change removes the SDK's duplicate application and moves tutorial qualification to the merged examples revision
6431e6a984c88eca6904b75b760a57d0e2edde16, verified against a pinned archive digest before extraction into ignored staging.The complete npm/Vite tutorial, snippet comparisons, guided patch, candidate-package builds and SDK host/transport browser qualification remain here. Application rules and controller tests moved with the application in examples PR #5. README navigation and tutorial copy use lowercase saga branding; the Blueprint records the source-ownership amendment. No SDK API or package version changes.
Validation: 136 documentation/consumer checks; 30 external-source/candidate/import checks; 27 Chromium tutorial checks; root and host TypeScript checks; archive-digest rejection checks; formatter/hooks and version policy. Candidate tests build all three tutorial checkpoints against packed SDK packages. Examples PR #5 separately qualified registry installation, local Node/Vite, Worker persistence/expiry and both-theme branded cards.
The canonical attribution remains https://saga-ai.dev/. Website routing and host connector-display behavior are separate from this source migration.