Skip to content

chore: move tutorial game ownership to examples - #361

Merged
timeleft-- merged 2 commits into
mainfrom
codex/external-game-brand
Oct 30, 2026
Merged

timeleft-- merged 2 commits into
mainfrom
codex/external-game-brand

Conversation

@timeleft--

Copy link
Copy Markdown
Member

The tic-tac-toe application now lives in saga-a2ui-examples, shared by its local Node/Vite build and hosted Worker. This change removes the SDK's duplicate application and moves tutorial qualification to the merged examples revision 6431e6a984c88eca6904b75b760a57d0e2edde16, verified against a pinned archive digest before extraction into ignored staging.

The complete npm/Vite tutorial, snippet comparisons, guided patch, candidate-package builds and SDK host/transport browser qualification remain here. Application rules and controller tests moved with the application in examples PR #5. README navigation and tutorial copy use lowercase saga branding; the Blueprint records the source-ownership amendment. No SDK API or package version changes.

Validation: 136 documentation/consumer checks; 30 external-source/candidate/import checks; 27 Chromium tutorial checks; root and host TypeScript checks; archive-digest rejection checks; formatter/hooks and version policy. Candidate tests build all three tutorial checkpoints against packed SDK packages. Examples PR #5 separately qualified registry installation, local Node/Vite, Worker persistence/expiry and both-theme branded cards.

The canonical attribution remains https://saga-ai.dev/. Website routing and host connector-display behavior are separate from this source migration.

@yia-mw-agent yia-mw-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the full merge-base (95c5708) to head (d36d68e) diff against main: 44 files; the SDK game directory and its rules/controller tests removed, the pinned external-source staging added, and the docs, blueprints and brand copy updated.

No material defects.

Evidence at d36d68e:

  • npm run stage:tutorial downloaded the examples archive at 6431e6a, verified the decompressed SHA-256 against scripts/tic-tac-toe-source.json, and staged apps/tic-tac-toe/game (the --strip-components=4 path is right). Changed bytes, bad gzip and an invalid pin are rejected before extraction, and the cache is written only after verification.
  • vitest on the stage, document, boundary, stack-imports, tic-tac-toe and guide tests: 6 files, 148 tests passed. This includes the candidate build and typecheck of all three tutorial checkpoints against packed SDK packages.
  • Root tsc -p tsconfig.json and the lit-host typecheck pass. The remaining references to examples/tic-tac-toe are only the negative assertion in scripts/tic-tac-toe.test.ts.
  • build-tic-tac-toe.ts against the staged source succeeded, and e2e/tic-tac-toe.spec.ts ran in Chromium (lit project): 27 passed.
  • Prettier check on the changed files passes. At review time the Version policy, documentation and advisory-lint CI jobs passed. The "Application types, builds, tests and release qualification" job was still pending, so I did not rely on it.

Non-blocking notes:

  • stageTutorialGame reads a cached archive without a size bound; it is verified by digest, so this is only a robustness observation.
  • .version-policy.json now lists the two staging files as development paths; this matches the PR's no-version-bump claim.

Helmet-Review-Request: #361 (comment)

@timeleft--
timeleft-- merged commit 07d3642 into main Oct 30, 2026
5 checks passed
@timeleft--
timeleft-- deleted the codex/external-game-brand branch October 30, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants