fix(dfns): migrate file records in lists - #370
Merged
Merged
Conversation
The v2 migration only folded `FILEIN|FILEOUT <path>` into a File field for `record` fields, so recarray items with the same pattern (FMI packagedata, SSM fileinput, LAK tables, SFR crosssections) kept separate keyword and string subfields. prt-fmi was instead hand-rewritten into three bare File fields, unlike gwt-fmi/gwe-fmi. Share file record detection between records and recarray items, take the path from the first untagged string after the mode keyword (FMI's leading flowtype is a variable tag, not the path), restrict subfield lookups to the field's block, and drop the prt-fmi special case. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wpbonelli
marked this pull request as ready for review
October 1, 2026 21:36
wpbonelli
added a commit
to modflowpy/pyphoenix-project
that referenced
this pull request
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the migration missed file records in lists (FMI packagedata, SSM fileinput, LAK tables, SFR crosssections), fix it