Skip to content

fix file records - #387

Merged
wpbonelli merged 2 commits into
modflowpy:developfrom
wpbonelli:fmi-file-records
Oct 2, 2026
Merged

wpbonelli merged 2 commits into
modflowpy:developfrom
wpbonelli:fmi-file-records

Conversation

@wpbonelli

Copy link
Copy Markdown
Member

wpbonelli and others added 2 commits October 1, 2026 19:28
modflow-devtools now migrates every FILEIN/FILEOUT input, including
recarray items, to a File field (MODFLOW-ORG/modflow-devtools#370), and
no longer rewrites prt-fmi into bare File fields. Codegen follows suit:

- File list-item columns get role "file", with direction from the DFN
  and any fixed keyword before it (SSM's SPC6, LAK's TAB6) as keyword=,
  instead of inferring both from FILEIN/FILEOUT prefix tokens
- a fixed keyword before a non-file column is an error rather than
  silently becoming a Path
- drop is_bare_file and its branches
- regenerate prt-fmi (class and grammar) as a packagedata list of
  (flowtype, fname), matching gwt/gwe-fmi

Pin modflow-devtools to the fix commit, ahead of modflowpy#371 (array-based aux),
which needs its own codegen changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@wpbonelli wpbonelli added this to the MVP milestone Oct 2, 2026
@wpbonelli wpbonelli added the bug Something isn't working label Oct 2, 2026
@wpbonelli
wpbonelli marked this pull request as ready for review October 2, 2026 02:49
@wpbonelli
wpbonelli merged commit 36d35e9 into modflowpy:develop Oct 2, 2026
16 checks passed
@wpbonelli
wpbonelli deleted the fmi-file-records branch October 2, 2026 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant