Skip to content

fix(dfns): fix shape bounds #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wpbonelli merged 2 commits into from
Sep 30, 2026
Merged

fix(dfns): fix shape bounds #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f203698
feat(dfns): support shape bounds
wpbonelli Sep 30, 2026
413fb60
docs(dfns): describe shape bounds generally
wpbonelli Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/chf-cdb.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@
}
},
"shape": [
"maxbound"
"<=maxbound"
]
}
},
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/chf-cdb.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ description = "integer value specifying the maximum number of critical depth bou
[blocks.period.fields.stress_period_data]
type = "list"
shape = [
"maxbound",
"<=maxbound",
]

[blocks.period.fields.stress_period_data.item]
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/chf-cdb.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ blocks:
optional: true
tagged: false
shape:
- maxbound
- <=maxbound
header:
fill_forward: true
field:
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/chf-chd.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@
}
},
"shape": [
"maxbound"
"<=maxbound"
]
}
},
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/chf-chd.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ description = "integer value specifying the maximum number of constant-head cell
[blocks.period.fields.stress_period_data]
type = "list"
shape = [
"maxbound",
"<=maxbound",
]

[blocks.period.fields.stress_period_data.item]
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/chf-chd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ blocks:
optional: true
tagged: false
shape:
- maxbound
- <=maxbound
header:
fill_forward: true
field:
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/chf-evp.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@
}
},
"shape": [
"maxbound"
"<=maxbound"
]
}
},
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/chf-evp.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ description = "integer value specifying the maximum number of evaporation cells
[blocks.period.fields.stress_period_data]
type = "list"
shape = [
"maxbound",
"<=maxbound",
]

[blocks.period.fields.stress_period_data.item]
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/chf-evp.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ blocks:
optional: true
tagged: false
shape:
- maxbound
- <=maxbound
header:
fill_forward: true
field:
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/chf-flw.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@
}
},
"shape": [
"maxbound"
"<=maxbound"
]
}
},
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/chf-flw.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ description = "integer value specifying the maximum number of inflow cells that
[blocks.period.fields.stress_period_data]
type = "list"
shape = [
"maxbound",
"<=maxbound",
]

[blocks.period.fields.stress_period_data.item]
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/chf-flw.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ blocks:
optional: true
tagged: false
shape:
- maxbound
- <=maxbound
header:
fill_forward: true
field:
Expand Down
10 changes: 8 additions & 2 deletions autotest/dfns/__snapshots__/v2.0.0.dev2/chf-oc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,10 @@
"steps": {
"type": "array",
"description": "save for each step specified in STEPS. This keyword may be used in conjunction with other keywords to print or save results for multiple time steps.",
"dtype": "integer"
"dtype": "integer",
"shape": [
"<=nstp"
]
}
}
}
Expand Down Expand Up @@ -223,7 +226,10 @@
"steps": {
"type": "array",
"description": "save for each step specified in STEPS. This keyword may be used in conjunction with other keywords to print or save results for multiple time steps.",
"dtype": "integer"
"dtype": "integer",
"shape": [
"<=nstp"
]
}
}
}
Expand Down
6 changes: 6 additions & 0 deletions autotest/dfns/__snapshots__/v2.0.0.dev2/chf-oc.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,9 @@ description = "save at the specified time step frequency. This keyword may be us
type = "array"
description = "save for each step specified in STEPS. This keyword may be used in conjunction with other keywords to print or save results for multiple time steps."
dtype = "integer"
shape = [
"<=nstp",
]

[blocks.period.fields.output.item.arms.printrecord]
type = "record"
Expand Down Expand Up @@ -202,6 +205,9 @@ description = "save at the specified time step frequency. This keyword may be us
type = "array"
description = "save for each step specified in STEPS. This keyword may be used in conjunction with other keywords to print or save results for multiple time steps."
dtype = "integer"
shape = [
"<=nstp",
]

[blocks.period.header]
fill_forward = true
Expand Down
4 changes: 4 additions & 0 deletions autotest/dfns/__snapshots__/v2.0.0.dev2/chf-oc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,8 @@ blocks:
description: save for each step specified in STEPS. This keyword may be used in
conjunction with other keywords to print or save results for multiple time steps.
dtype: integer
shape:
- <=nstp
printrecord:
type: record
optional: true
Expand Down Expand Up @@ -191,6 +193,8 @@ blocks:
description: save for each step specified in STEPS. This keyword may be used in
conjunction with other keywords to print or save results for multiple time steps.
dtype: integer
shape:
- <=nstp
header:
fill_forward: true
field:
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/chf-pcp.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@
}
},
"shape": [
"maxbound"
"<=maxbound"
]
}
},
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/chf-pcp.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ description = "integer value specifying the maximum number of precipitation cell
[blocks.period.fields.stress_period_data]
type = "list"
shape = [
"maxbound",
"<=maxbound",
]

[blocks.period.fields.stress_period_data.item]
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/chf-pcp.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ blocks:
optional: true
tagged: false
shape:
- maxbound
- <=maxbound
header:
fill_forward: true
field:
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/chf-zdg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@
}
},
"shape": [
"maxbound"
"<=maxbound"
]
}
},
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/chf-zdg.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ description = "integer value specifying the maximum number of zero-depth-gradien
[blocks.period.fields.stress_period_data]
type = "list"
shape = [
"maxbound",
"<=maxbound",
]

[blocks.period.fields.stress_period_data.item]
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/chf-zdg.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ blocks:
optional: true
tagged: false
shape:
- maxbound
- <=maxbound
header:
fill_forward: true
field:
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/gwe-ctp.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@
}
},
"shape": [
"maxbound"
"<=maxbound"
]
}
},
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/gwe-ctp.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ description = "integer value specifying the maximum number of constant temperatu
[blocks.period.fields.stress_period_data]
type = "list"
shape = [
"maxbound",
"<=maxbound",
]

[blocks.period.fields.stress_period_data.item]
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/gwe-ctp.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ blocks:
optional: true
tagged: false
shape:
- maxbound
- <=maxbound
header:
fill_forward: true
field:
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/gwe-esl.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@
}
},
"shape": [
"maxbound"
"<=maxbound"
]
}
},
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/gwe-esl.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ description = "integer value specifying the maximum number of source cells that
[blocks.period.fields.stress_period_data]
type = "list"
shape = [
"maxbound",
"<=maxbound",
]

[blocks.period.fields.stress_period_data.item]
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/gwe-esl.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ blocks:
optional: true
tagged: false
shape:
- maxbound
- <=maxbound
header:
fill_forward: true
field:
Expand Down
10 changes: 8 additions & 2 deletions autotest/dfns/__snapshots__/v2.0.0.dev2/gwe-oc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,10 @@
"steps": {
"type": "array",
"description": "save for each step specified in STEPS. This keyword may be used in conjunction with other keywords to print or save results for multiple time steps.",
"dtype": "integer"
"dtype": "integer",
"shape": [
"<=nstp"
]
}
}
}
Expand Down Expand Up @@ -205,7 +208,10 @@
"steps": {
"type": "array",
"description": "save for each step specified in STEPS. This keyword may be used in conjunction with other keywords to print or save results for multiple time steps.",
"dtype": "integer"
"dtype": "integer",
"shape": [
"<=nstp"
]
}
}
}
Expand Down
6 changes: 6 additions & 0 deletions autotest/dfns/__snapshots__/v2.0.0.dev2/gwe-oc.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,9 @@ description = "save at the specified time step frequency. This keyword may be us
type = "array"
description = "save for each step specified in STEPS. This keyword may be used in conjunction with other keywords to print or save results for multiple time steps."
dtype = "integer"
shape = [
"<=nstp",
]

[blocks.period.fields.output.item.arms.printrecord]
type = "record"
Expand Down Expand Up @@ -186,6 +189,9 @@ description = "save at the specified time step frequency. This keyword may be us
type = "array"
description = "save for each step specified in STEPS. This keyword may be used in conjunction with other keywords to print or save results for multiple time steps."
dtype = "integer"
shape = [
"<=nstp",
]

[blocks.period.header]
fill_forward = true
Expand Down
4 changes: 4 additions & 0 deletions autotest/dfns/__snapshots__/v2.0.0.dev2/gwe-oc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,8 @@ blocks:
description: save for each step specified in STEPS. This keyword may be used in
conjunction with other keywords to print or save results for multiple time steps.
dtype: integer
shape:
- <=nstp
printrecord:
type: record
optional: true
Expand Down Expand Up @@ -177,6 +179,8 @@ blocks:
description: save for each step specified in STEPS. This keyword may be used in
conjunction with other keywords to print or save results for multiple time steps.
dtype: integer
shape:
- <=nstp
header:
fill_forward: true
field:
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/gwf-chd.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@
}
},
"shape": [
"maxbound"
"<=maxbound"
]
}
},
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/gwf-chd.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ description = "integer value specifying the maximum number of constant-head cell
[blocks.period.fields.stress_period_data]
type = "list"
shape = [
"maxbound",
"<=maxbound",
]

[blocks.period.fields.stress_period_data.item]
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/gwf-chd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ blocks:
optional: true
tagged: false
shape:
- maxbound
- <=maxbound
header:
fill_forward: true
field:
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/gwf-csub.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@
}
},
"shape": [
"maxsig0"
"<=maxsig0"
]
}
},
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/gwf-csub.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ tagged = false
[blocks.period.fields.stress_period_data]
type = "list"
shape = [
"maxsig0",
"<=maxsig0",
]

[blocks.period.fields.stress_period_data.item]
Expand Down
2 changes: 1 addition & 1 deletion autotest/dfns/__snapshots__/v2.0.0.dev2/gwf-csub.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,7 @@ blocks:
tagged: false
time_series: true
shape:
- maxsig0
- <=maxsig0
header:
fill_forward: true
field:
Expand Down
Loading
Loading