Repository navigation
fix(dfns): fix shape bounds - #369
Merged
Merged
Conversation
A shape extent is exact unless prefixed with an inequality operator (<, <=, >, >=), which may now bound any valid shape expression. Add split_bound() for consumers. Document bounds in the spec. The dev2 migration keeps v1's `<` marker as `<=`, marks confirmed upper bounds (maxbound, maxhfb, maxsig0, maxats), and fills in the missing sim-tdis and utl-ats perioddata shapes. Fix utl-ts shapes: sfacval is sized by time_series_names, the single SFAC value is a scalar, and time_series_names is no longer renamed to interpolation_method. Correct the spec on advanced package list shapes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Keep the spec free of DFN specifics: use placeholder dimensions in shape examples and drop per-package details. Move the note on the legacy `<` marker and the migration's bound fix-ups to the migration docs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wpbonelli
added a commit
to modflowpy/pyphoenix-project
that referenced
this pull request
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow shapes to be prefixed with an inequality operator (<, <=, >, >=). Add
split_bound()function. Document bound rules in the spec. The v1 DFNs use<where they really mean<=, switch it. Fix some shapes the migration previously missed.