chg: add reciprocal ownership and manufacturing relationships - #527
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bad4c76bc9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "version": 52 | ||
| } No newline at end of file | ||
| "version": 53 | ||
| } |
There was a problem hiding this comment.
Match the formatter's no-newline output
The newly added trailing newline makes this file noncanonical and causes every Travis run to fail: .travis.yml:16 invokes validate_all.sh, which formats the file and rejects any resulting diff at validate_all.sh:6-12, while jq_all_the_things.sh:26 uses jq -S -j; jq --help defines --join-output as producing output without a newline. Running that exact formatter removes this final LF, so validation exits before reaching the schema checks.
Useful? React with 👍 / 👎.
Motivation
operator-of/owner-of/controlsusable in MISP by declaring themispformat and adding missing opposites.Description
relationships/definition.jsonto add opposites foroperator-of(operated-by),owner-of(owned-by), andcontrols(controlled-by) and addedmispto the existing entries'formatlists.operated-by,owned-by,controlled-by, plusmanufacturesandmanufactured-byto model manufacturers and their products.52to53and committed the change as1fa5676with messagechg: [relationships] add UAV ownership relationships.Testing
python -m json.tool relationships/definition.jsonwhich succeeded and validated JSON syntax../tools/validate_opposites.shand a custom Python check for unique names and reciprocaloppositefields, both succeeded.git diff --checkand ensured there were no diff/whitespace issues after the commit.jsonschema -i relationships/definition.json schema_relationships.json) was not run because thejsonschemaCLI is not available in the environment.Codex Task