Skip to content

chg: add reciprocal ownership and manufacturing relationships - #527

Merged
adulau merged 1 commit into
mainfrom
codex/review-and-update-relationships-for-misp-galaxy
Aug 9, 2026
Merged

chg: add reciprocal ownership and manufacturing relationships#527
adulau merged 1 commit into
mainfrom
codex/review-and-update-relationships-for-misp-galaxy

Conversation

@adulau

@adulau adulau commented Aug 9, 2026

Copy link
Copy Markdown
Member

Motivation

  • The UAV-related model lacked reciprocal ownership/operator/controller relationships and a link to manufacturers which impedes bidirectional traversal and consistent MISP usage.
  • Make existing operator-of/owner-of/controls usable in MISP by declaring the misp format and adding missing opposites.
  • Version bump is required after adding new relationship entries to keep the definitions consistent.

Description

  • Updated relationships/definition.json to add opposites for operator-of (operated-by), owner-of (owned-by), and controls (controlled-by) and added misp to the existing entries' format lists.
  • Added the new inverse relationship definitions: operated-by, owned-by, controlled-by, plus manufactures and manufactured-by to model manufacturers and their products.
  • Incremented the relationships file version from 52 to 53 and committed the change as 1fa5676 with message chg: [relationships] add UAV ownership relationships.

Testing

  • Ran python -m json.tool relationships/definition.json which succeeded and validated JSON syntax.
  • Ran ./tools/validate_opposites.sh and a custom Python check for unique names and reciprocal opposite fields, both succeeded.
  • Ran git diff --check and ensured there were no diff/whitespace issues after the commit.
  • Full JSON Schema CLI validation (jsonschema -i relationships/definition.json schema_relationships.json) was not run because the jsonschema CLI is not available in the environment.

Codex Task

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bad4c76bc9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

"version": 52
} No newline at end of file
"version": 53
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Match the formatter's no-newline output

The newly added trailing newline makes this file noncanonical and causes every Travis run to fail: .travis.yml:16 invokes validate_all.sh, which formats the file and rejects any resulting diff at validate_all.sh:6-12, while jq_all_the_things.sh:26 uses jq -S -j; jq --help defines --join-output as producing output without a newline. Running that exact formatter removes this final LF, so validation exits before reaching the schema checks.

Useful? React with 👍 / 👎.

@adulau
adulau merged commit 3ba942a into main Aug 9, 2026
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant