Skip to content

tests/ui-smoke: let linuxcnc shut down before signalling its group #4701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
grandixximo wants to merge 2 commits into
base: master
Choose a base branch
from
Open

tests/ui-smoke: let linuxcnc shut down before signalling its group #4701

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db0f96e
tests/ui-smoke: let linuxcnc shut down before signalling its group
grandixximo Oct 18, 2026
deeeb70
tests/tp/circle-curvature: drop the leftover ${SUDO}
grandixximo Oct 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tests/tp/circle-curvature/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#!/bin/sh
set -e

# shellcheck disable=SC2086
${SUDO} halcompile --install curvaturecheck.c >/dev/null
halcompile --install curvaturecheck.c >/dev/null
halrun curvature.hal
echo 'circle curvature: OK'
11 changes: 11 additions & 0 deletions tests/ui-smoke/_lib/quit-launch.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,17 @@ xvfb-run -a --server-args="-screen 0 $UI_SMOKE_XVFB_SCREEN" \
RC=0
fi

# A GUI that quit makes linuxcnc shut down by itself; let it.
# A SIGTERM to the group while it unloads kills the halcmd and
# rtapi_app clients halfway, and linuxcnc then unloads a second
# time on top of the first, leaving shared memory behind.
if [ "$RC" = 0 ]; then
for _ in $(seq 30); do
kill -0 "$LINUXCNC_PID" 2>/dev/null || break
sleep 1
done
fi

# Tear down whatever is left (task/motion, or the GUI on failure).
kill -TERM -- -"$LINUXCNC_PID" 2>/dev/null || true
for _ in $(seq 30); do
Expand Down
Loading