Repository navigation
tests/ui-smoke: let linuxcnc shut down before signalling its group - #4701
Open
grandixximo wants to merge 2 commits into
Open
grandixximo wants to merge 2 commits into
grandixximo wants to merge 2 commits into
Conversation
Once the GUI had quit, quit-launch.sh sent SIGTERM to the whole linuxcnc
process group at once. linuxcnc was then already shutting down after
its GUI, so under load the signal reached it while it unloaded: the
halcmd and rtapi_app clients died halfway ("child did not exit
normally"), linuxcnc's SIGTERM trap ran its cleanup a second time on
top of the first, and the motion shared memory was left behind (SHMERR
in touchy-quit, LinuxCNC#4669).
After a clean quit the launcher now waits up to 30 s for linuxcnc to
exit by itself, and only then signals what is left. With a component
that takes 1 s to unload, touchy-quit gave that SHMERR on every run
and now passes.
runtests no longer sets SUDO since the tests stopped using sudo, and the skip file keeps the test off installed packages.
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #4669. @hdiethelm, this is the touchy-quit SHMERR from your last round.
Once the GUI had quit, quit-launch.sh sent SIGTERM to the whole linuxcnc process group at once. linuxcnc was already shutting down after its GUI, so under load the signal arrived while it unloaded: the halcmd and rtapi_app clients died halfway ("child did not exit normally"), linuxcnc's SIGTERM trap ran its cleanup a second time on top of the first, and the motion shared memory was left behind. After a clean quit the launcher now waits up to 30 s for linuxcnc to exit by itself, and only then signals what is left.
With a component that takes 1 s to unload added to linuxcnc's cleanup, touchy-quit printed the same lines as your log and the SHMERR on every run; with this change it passes.
The second commit drops the
${SUDO}left in tests/tp/circle-curvature, which came in after #4663.