Skip to content

Issue 1051: Fix up audit comments for cross-type imports and updates that update storage data #7579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-susanh merged 3 commits into from
Apr 14, 2026
+4 −2
Merged

Issue 1051: Fix up audit comments for cross-type imports and updates that update storage data #7579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bcff32d
GH Issue 1051: ensure audit comments carry through after processing p…
labkey-susanh Apr 13, 2026
f1e1930
Update wording on PR tasks
labkey-susanh Apr 13, 2026
7452584
StorageLocation is already in the map
labkey-susanh Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@
<!-- list of standard tasks (remove this comment to enable)
#### Tasks 📍
- [ ] Manual Testing
- [ ] Needs Automation
- [ ] Test Automation
- [ ] Verify Fix
-->
-->
2 changes: 2 additions & 0 deletions experiment/src/org/labkey/experiment/ExpDataIterators.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3165,6 +3165,8 @@ private TypeData createSampleHeaderRow(ExpSampleTypeImpl sampleType, Container c
validFields.add("Storage Unit Label");
// For consistency with other storage fields that are imported without spaces in the names
validFields.add("EnteredStorage");
validFields.add("StorageComment"); // GH Issue 1051
validFields.add("Storage Comment");
List<Integer> fieldIndexes = new IntArrayList();
Map<Integer, String> dependencyIndexes = new IntHashMap<>();
List<String> header = new ArrayList<>();
Expand Down
Loading