Issue 1051: Fix up audit comments for cross-type imports and updates that update storage data#7579
Open
labkey-susanh wants to merge 3 commits intorelease26.3-SNAPSHOTfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Issue 1051: Because we support the use of a special column (
StorageComment) for adding audit comments about storage actions on a per-line basis during file import, we update the audit comment in the data iterator context to override any comment provided at the file level. This works just fine when doing a single-type or single-container import but when doing a cross-type or cross-container import, the file-level comment is lost after the first file of samples is processed.Related Pull Requests
Changes
StorageCommentfield to the split files for a cross-type or cross-container import