Skip to content

Install VC Runtime On Downloading windows builds if not installed #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheForce172 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Install VC Runtime On Downloading windows builds if not installed #367

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d741ef
Install VC Runtime On Downloading windows builds if not installed
TheForce172 Mar 31, 2026
8d3eda3
Download and run installer rather than embed
TheForce172 Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
122 changes: 119 additions & 3 deletions Knossos.NET/ViewModels/Templates/Tasks/InstallBuild.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,79 @@
using Avalonia.Threading;
using Knossos.NET.Classes;
using Knossos.NET.Models;
using Knossos.NET.Views;
using Microsoft.Win32;
using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.IO;
using System.Linq;
using System.Runtime.InteropServices;
using System.Security.Cryptography;
using System.Threading.Tasks;
using System.Threading;
using Knossos.NET.Classes;
using System.Threading.Tasks;

namespace Knossos.NET.ViewModels
{
public partial class TaskItemViewModel : ViewModelBase
{
private async Task<bool> InstallVCRedist(bool is86 = false) {
var fileTask = new TaskItemViewModel(); // Crete new task
await Dispatcher.UIThread.InvokeAsync(() => TaskList.Insert(0, fileTask)); //insert task into this job TaskList
Info = "Tasks: " + ProgressCurrent + "/" + (++ProgressBarMax); //Update progress
var path = "";
if (is86) { path = Path.Combine(KnUtils.GetKnossosDataFolderPath(), "vc_redist.x86.exe"); }
else { path = Path.Combine(KnUtils.GetKnossosDataFolderPath(), "vc_redist.x64.exe"); }
var fileUrl = "";
if (is86)
{
fileUrl = "https://aka.ms/vc14/vc_redist.x86.exe";
} //installs both x64 and arm versons
else { fileUrl = "https://aka.ms/vc14/vc_redist.x64.exe"; }
var result = await fileTask.DownloadFile(fileUrl, path, "Downloading VCRedist", false, null, cancellationTokenSource); // Start and await to finish
//Always check for cancel before executing the file
if (cancellationTokenSource.IsCancellationRequested)
{
throw new TaskCanceledException();
}

if (result.HasValue && result.Value)
{
//Assembly assembly = Assembly.GetExecutingAssembly();
//using Stream resourceStream = assembly.GetManifestResourceStream(resourceName)??throw new Exception("Resource not found!");
//Execute the installer
Info = "Tasks: " + (++ProgressCurrent) + "/" + ProgressBarMax;
//Retry a couple of times incase we get locked out by av temporealy
int retries = 5;
while (retries > 0)
{
try
{
Process.Start(new ProcessStartInfo
{
FileName = path,
Arguments = "/install /quiet /norestart",
Verb = "runas",
UseShellExecute = true
}).WaitForExit();
break; // Success!
}
catch (System.ComponentModel.Win32Exception ex) when (ex.NativeErrorCode == 32) // Error code for "File in use"
{
retries--;
if (retries == 0) throw;
System.Threading.Thread.Sleep(500); // Wait 500ms for AV to finish scanning
}
}

if (File.Exists(path)) File.Delete(path);
return true;
}
else
{
throw new Exception("Error while downloading file: " + fileUrl);
}
}
public async Task<FsoBuild?> InstallBuild(FsoBuild build, FsoBuildItemViewModel sender, CancellationTokenSource? cancelSource = null, Mod? modJson = null, List<ModPackage>? modifyPkgs = null, bool cleanupOldVersions = false)
{
string? modPath = null;
Expand Down Expand Up @@ -433,9 +493,65 @@ public partial class TaskItemViewModel : ViewModelBase
//Update version editor if needed
DeveloperModsViewModel.Instance?.UpdateVersionManager(modJson.id);
}
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
{
bool installx86 = false;
bool install64 = false;
//Determine the cpu arch for vcredist that we need to download, if we need to download, from the FSO build arch NOT the host cpu arch.
foreach (var ex in newBuild.executables)
{
if (ex.arch == FsoExecArch.x86 || ex.arch == FsoExecArch.x86_avx || ex.arch == FsoExecArch.x86_avx2)
{
installx86 = true;
}
if (ex.arch == FsoExecArch.arm64 || ex.arch == FsoExecArch.x64 || ex.arch == FsoExecArch.x64_avx || ex.arch == FsoExecArch.x64_avx2)
{
install64 = true;
}
}
if (installx86)
{
string keyPath = @"SOFTWARE\Microsoft\VisualStudio\14.0\VC\Runtimes\x86";
using (RegistryKey key = Registry.LocalMachine.OpenSubKey(keyPath))
{
if (key != null)
{
// 'Bld' is a DWORD representing the build version
object bldValue = key.GetValue("Bld");
if (bldValue != null && int.TryParse(bldValue.ToString(), out int bld))
{
// Example: 2022 runtimes typically have build numbers > 30000
installx86 = false;
}
}
}
}
if (install64)
{
string keyPath = @"SOFTWARE\Microsoft\VisualStudio\14.0\VC\Runtimes\x64";
using (RegistryKey key = Registry.LocalMachine.OpenSubKey(keyPath))
{
if (key != null)
{
// 'Bld' is a DWORD representing the build version
object bldValue = key.GetValue("Bld");
if (bldValue != null && int.TryParse(bldValue.ToString(), out int bld))
{
// Example: 2022 runtimes typically have build numbers > 30000
install64 = false;
}
}
}
}
if (installx86)
{
await InstallVCRedist(true);
}
if (install64) { await InstallVCRedist(false); }
}

IsCompleted = true;
CancelButtonVisible = false;

//Re-run Dependencies checks
MainWindowViewModel.Instance?.RunModStatusChecks();

Expand Down