Install VC Runtime On Downloading windows builds if not installed#367
Install VC Runtime On Downloading windows builds if not installed#367TheForce172 wants to merge 2 commits intoKnossosNET:mainfrom
Conversation
notimaginative
left a comment
There was a problem hiding this comment.
This needs to support the x86 and arm64 versions as well.
Also the exe should definitely NOT be bundled with KNet. There are permalinks available for them which should be used with a download task, as needed.
|
Yes i agree, there is no need to embed the redistributable, it can be downloaded. In fact eventually i want to get rid of all embedded executables. You did it ok, but instead of embedding it, download it, something like this: //Determine the cpu arch for vcredist that we need to download, if we need to download, from the FSO build arch NOT the host cpu arch. //Download VC redist var destPath = Path.Combine(KnUtils.GetKnossosDataFolderPath(),"{filename}"); //save to knossos data folder in appdata //not sure if these are the right ones please check vas fileUrl = ""; //Always check for cancel before executing the file if (result.HasValue && result.Value) also, feel free to create one or more private functions inside InstallBuild.cs if you think will make the code shorter. |
Also adds x86 option
Looks okay as far as I can tell, but ShivanSpS knows the code far better than I do so I'll leave the review to him.
I did verify that the x64 vcredist install includes both x64 and arm64 libs, and that the x64 registry key checked here exists on an arm64 system as well, so there's no issue there.
Does what the title says. Accompaniment to scp-fs2open/fs2open.github.com#7334 to make sure that users have the necessary dlls installed when we start compiling dynamically.