-
Notifications
You must be signed in to change notification settings - Fork 80
Expose all project fields via GraphQL #3432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Requesting a double review again. I'm mostly looking for feedback on these things:
|
| enum BugTracker { | ||
| GITHUB @enum(value: "GitHub") | ||
| BUGANIZER @enum(value: "Buganizer") | ||
| JIRA @enum(value: "JIRA") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add GitLab issues as a supported type of bug tracker (not in this PR)
25953fb to
8054b3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With these latest changes, there are several more broken links that appear on the Project menu that would originally have been hidden or valid links. Each of the broken links seem to go to http://unknown :
<li>
<a class="cdash-link" ng-href="http://unknown" href="http://unknown">Home</a>
</li>
<!-- ngIf: cdash.documentation.replace('https://', '').replace('http://', '').trim() !== '' --><li ng-if="cdash.documentation.replace('https://', '').replace('http://', '').trim() !== ''" class="ng-scope">
<a class="cdash-link" ng-href="http://unknown" href="http://unknown">Documentation</a>
</li><!-- end ngIf: cdash.documentation.replace('https://', '').replace('http://', '').trim() !== '' -->
<!-- ngIf: cdash.vcs.replace('https://', '').replace('http://', '').trim() !== '' --><li ng-if="cdash.vcs.replace('https://', '').replace('http://', '').trim() !== ''" class="ng-scope">
<a class="cdash-link" ng-href="http://unknown" href="http://unknown">Repository</a>
</li><!-- end ngIf: cdash.vcs.replace('https://', '').replace('http://', '').trim() !== '' -->
<!-- ngIf: cdash.bugtracker.replace('https://', '').replace('http://', '').trim() !== '' --><li ng-if="cdash.bugtracker.replace('https://', '').replace('http://', '').trim() !== ''" ng-class="::{endsubmenu: cdash.projectrole}" class="ng-scope endsubmenu">
<a class="cdash-link" ng-href="http://unknown" href="http://unknown"> Bug Tracker</a>
</li><!-- end ngIf: cdash.bugtracker.replace('https://', '').replace('http://', '').trim() !== '' -->
<li class="endsubmenu">
<a class="cdash-link" ng-href="http://localhost:8080/projects/2/members" href="http://localhost:8080/projects/2/members">Members</a>
</li>
<li class="endsubmenu">
<a class="cdash-link" ng-href="http://localhost:8080/subscribeProject.php?projectid=2" href="http://localhost:8080/subscribeProject.php?projectid=2">Notifications</a>
</li>
With master, the Home link was a pointer to CDash and the others were hidden,
8054b3c to
d0244f4
Compare
josephsnyder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Links look good now, no other visible issues on manual testing,
This PR adds all of the missing Project fields and solidifies the database types to better enforce our constraints. I plan to follow this work with a new `updateProject` mutation.
d0244f4 to
ecea71a
Compare
This PR adds all of the missing Project fields and solidifies the database types to better enforce our constraints. I plan to follow this work with a new
updateProjectmutation.