Clean up legacy build error and build failure models #3433
Merged
+231
−372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
force-pushed
the
build-error-failure-business-logic
branch
from
341a5fd to
59ba1a0
Compare
josephsnyder
requested changes
Feb 4, 2026
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
I've got some errors on attempting to load Build Error and Build warnings in both new and old data. Both are 500 responses:
str_contains(): Argument #1 ($haystack) must be of type string, null givenbasename(): Argument #1 ($path) must be of type string, null given
Each prevents the load of information into each page
Using testing Trilinos Data:
Using newly submitted build failures:
williamjallen
force-pushed
the
build-error-failure-business-logic
branch
from
59ba1a0 to
90277c5
Compare
Collaborator
Author
|
@josephsnyder It looks like that error was caused by reviewing #3432 and then switching to this branch (the same thing that caused conflicts). I just rebased, and the error should be resolved. |
josephsnyder
approved these changes
Feb 5, 2026
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
Seems like it. No issues with page load now. LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incremental progress towards the eventual combination of these models. The last significant difference between these models is the build failure arguments, which I plan to address in a follow-up PR.